Code smells about agent HOT 5 CLOSED

I figured the immediate resolution was intended, since that's also the behavior for when delay is 0.

Also, the createTimeout returns either null, a non-resolving Promise, a {start, clear} object, or an inscrutable wrapper promise. And it has an argument called signal which seems to be given an AbortController, not an AbortSignal?

This code is an impressive fractal of WTF!

from agent.

Thanks @rotu! Core feedback addressed.

First array element is now thrown:

util.js has been removed, and I couldn't find any non-resolving Promises.

from agent.

Due to the way once works, this expression throws an Array containing a single Error instead of the probably intended Error.

This is a mistake and should be fixed. Nice catch!

This code creates a non-resolving promise (maybe instead of an immediately-resolving Promise?).

This could use a comment, or a refactor. This code path is only used in a Promise.race so passing a non-resolving promise is done on purpose if no timeout is passed in. Using an immediately resolving promise would make it immediately resolve the Promise.race which is not what is wanted.

from agent.

If the promise never resolves, what is it racing?

from agent.

oh ... if no timeout is passed. We should just return the original promise then.

ETA I think a bit of a refactor is in order here too. These are good catches!

from agent.