novasamatech / nova-ios-app Goto Github PK

We are looking for a real-world app to test Wallet Connect integration for the staking dashboard, is it possible to do so with Nova Wallet?

Related PR (WIP): polkadot-cloud/polkadot-staking-dashboard#907

Thank you!

Polkadot and Kusama nominator controller accounts are being deprecated

This is an issue to notify the maintainers of this repo that nominator controller accounts are being deprecated on Polkadot and Kusama, in favour of proxy accounts. In an upcoming runtime upgrade (version and date is yet to be determined), 2 call signatures of the staking pallet will change. These are breaking changes for UIs, so UIs will need to update their codebases when the changes come into effect.

Call Changes

The staking.bond and staking.setController call signatures have now changed in the Substrate codebase PR here, and will take effect in a future runtime upgrade.

• set_controller(controller) will become set_controller(). This call will simply set the controller account to the caller's stash account, if it is not already.
• bond(controller, value, payee) will become bond(value, payee). This call will now set the caller as the controller account (same as the stash).

UIs can prepare now by adding a controller deprecation message, and allow stakers to change their controller accounts back to their stash using the existing staking.setController(controller) call. The Polkadot staking dashboard recently deployed this functionality and may be useful as reference code.

Next Steps

• A follow-up message will be made when we know when these changes will be on Westend, giving UIs time to test any needed changes.
• Follow-up messages will be made here when we know the runtime version and date of the change on Polkadot and Kusama.

Other Resources

• Polkadot Forum Discussion: https://forum.polkadot.network/t/staking-controller-deprecation-plan-staking-ui-leads-comms/2748

The Nova wallet shows a locked DOT balance for participation in Acala's liquid crowdloan, even though the Acala protocol (Acala's Liquid Crowdloan vault) owns those DOT tokens, not my wallet.

Not sure if the same issue exists for other liquid crowdloans.

I hope you find this issue worth fixing.

Feature request

We are implementing "Pay with Polkadot" Point-of-Sale feature here:
https://github.com/metaspan/metapay

The solution is opensource and can be self-hosted by any vendor / merchant.

Use cases

1. Point-of-sale / Kiosk: generate QRcode with all relevant data - user scans with wallet and approves payment
   substrate://<address>:<genesisHash>:amount=1&reference=ref123
   The POS module can watch the address for any payment with reference, and mark the payment as complete.

2. Webshop: Send a link to user to request payment
   https://pay.metaspan.io/paymentRequest/<address>:<genesisHash>?amount=1&reference=ref123 (to be implemented shortly ;)
   The browser will display a QRcode for wallet to scan
   Also, if available, will connect to polkadot.js (in the browser)
   An optional callback will notify the webshop that payment is done / error.

Broadly, it will embrace similar work already done at Solana Pay
https://github.com/solana-labs/solana-pay/blob/master/SPEC.md

Nova Wallet should support additional fields via URL encoding in the comment

Current support - a QR code with:
substrate:<walletid>:<genesisHash>[:<comment>] - is supported

We need support for:
substrate:[//]<walletid>:<genesisHash>:[?]<url-encoded-fields>

Options for detecting additional fields

const parts = decodedQRString.split(':')
const protocol    = parts[0]
const address     = parts[1]
const genesisHash = parts[2]
const comment     = parts[3]

// Option 1
if (address.startsWith('//')) {}

// Option 2
if (comment && comment.startsWith('?')) {}

Example handler:

const parts = decodedQRString.split(':')
const protocol = parts[0]
if (protocol === 'substrate') {
  const address = parts[1]
  const comment = parts[3]
  if (address.startsWith('//') || ( comment && comment.startsWith('?') ) ) {
    // we have URL-encoded `comment` field
    /*
      [?]amount=<amount>
      &reference=<reference>
      &label=<label>
      &message=<message>
      &memo=<memo>
    */
  } else {
    // simple QR format
  }
} else {
  console.error('Invalid protocol')
}

I added our DOT Pool #18 Stash Address: 13UVJyLnbVp8c4FQeiGDrYotodEcyAzE8tipNEMc61UBJAH4

The DOT figure is correct. Why is it showing KSM...?