Git Product home page Git Product logo

nosto-jtlshop's People

Contributors

anttip avatar mridang avatar petterisusi avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nosto-jtlshop's Issues

Make size of images configurable

Currently, the highest resolution image of a product is exported to Nosto. Most likely these are images with 500x500 or bigger resolution.

This is suboptimal, because the prefered method is to use the images from our own domain rather than the thumbnails provided by nosto.

The rationale behind this is keep the loading times of our page as low as possible. You can see the impact of loading foreign images here:

https://developers.google.com/speed/pagespeed/insights/?url=click-licht.de&tab=desktop

Leverage browser caching for the following cacheable resources:
http://connect.nosto.com/include/v7khqc8z (10 minutes)
http://d2d9p2t5jvcryy.cloudfront.net/v7khqc8z/1/164114716 MA (60 minutes)
http://d2d9p2t5jvcryy.cloudfront.net/v7khqc8z/1/16464 VHT (60 minutes)
...
http://d2d9p2t5jvcryy.cloudfront.net/v7khqc8z/1/24173700 PH (60 minutes)

The good thing is that JTL-Shop automaticly generates thumbnails in other (user configurable) resolutions and exposes the paths inside the code:

$article->Bilder[0]->cPfadGross
$article->Bilder[0]->cPfadNormal
$article->Bilder[0]->cPfadKlein
$article->Bilder[0]->cPfadMini

image

A Setting inside the Nosto-Plugin which of these resolutions to take by default would be awesome and could solve our issues.

If you need any help on this please give me a go, i'm willing to implement and share it

Slashes in category names are not being escaped

There might be a case where category names contain slashes, such as "Strahler / Erdspieße". When the plugin writes the nosto-category tag, something like this will happen:

<div class="nosto_category" style="display:none">/Aussenleuchten/Strahler / Erdspieße</div>

The "slash" character is not being escaped and there is danger that the nosto backend handles it as 3 categories ["Aussenleuchten", "Stahler", "Erdspieße"] rather then the correct version ["Aussenleuchten", "Strahler / Erdspieße"]

For reference see:
http://www.click-licht.de/Strahler-Erdspiesse

Please close this issue if i'm mistaken here, as i have no insights on how Nosto handles this on the backend.

Paypal Payment issue

After pressing "purchase" on order overview page in JTL shop platform, user is sent to order confirmation page. After 3 seconds, user is redirected to paypal for executing payment.

Although paypal can be set up to send the user back after to order confirmation page, JTL uses parameters to create order confirmation page.

Result is: no order is seen by nosto.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.