nopsolutions / 2checkout-plugin-for-nopcommerce Goto Github PK

3. On the main menu select "Account" then "Site Management".
   should become
   On the main menu select "Integrations" then "Webhooks & API".

4. Add a new point as below:
   In the section "Instant Notification System (INS)" you have to tick the "Enable INS" checkbox.

5. Copy this URL: {GENERATED_URL_HERE} and paste it into "Approved URL".
   should be replaced with
   Copy this URL: {GENERATED_URL_HERE} and paste it into "Approved URL". Do the same on the "INS Settings" tab.

Details: https://verifone.cloud/docs/2checkout/API-Integration/01Start-using-the-2Checkout-API/2Checkout-API-general-information/Migration_guide_SHA2_SHA3

I have opened 2checkout account, activated sendbox, installed nopcommerce 2checkout plugin v4.5, configured it properly and when tried to pay order I keep getting PE106 error message. Then I wrote to 2checkout customer support and they replied with the following message:

I noticed that you are using the old Legacy cart wich is no longer supported and can cause some issues. We strongly recommend switching to our new and updated cart, ConvertPlus. Please see the documentation below:

https://verifone.cloud/docs/2checkout/Documentation/07Commerce/2Checkout-ConvertPlus

When can we expect that you are going to migrate nopcommerce 2checkout plugin to new cart, ConvertPlus?

Thanks,
DJ.

Hi,

In the Controllers/PaymentTwoCheckoutController.cs

Line 204, to change the payment status into Paid:
if (messageType.ToUpperInvariant() == "FRAUD_STATUS_CHANGED" && fraudStatus == "pass" && (invoiceStatus == "approved" || paymentType == "paypal ec")) { newPaymentStatus = PaymentStatus.Paid; }

I've had to add the invoiceStatus == "deposited" on this line:
&& (invoiceStatus == "approved" || invoiceStatus == "deposited" || paymentType == "paypal ec"))

Because for some orders with credit cards, this is shown first:
The "approved" is only shown under "ORDER_CREATED"

2Checkout IPN:
sale_id:
invoice_id:
message_type: ORDER_CREATED
invoice_status: approved
fraud_status: wait
payment_type: credit card
New payment status: Pending

Then followed by below after 8 seconds:
invoice status was changed to "deposited".

2Checkout IPN:
sale_id:
invoice_id:
message_type: FRAUD_STATUS_CHANGED
invoice_status: deposited
fraud_status: pass
payment_type: credit card
New payment status: Pending

And lastly:

2Checkout IPN:
sale_id:
invoice_id:
message_type: INVOICE_STATUS_CHANGED
invoice_status: deposited
fraud_status: pass
payment_type: credit card
New payment status: Pending

The credit card gets approved before the fraud status passed. And when the fraud status pass, the credit card is already marked as deposited, and the payment type did not change to paypal_ec...

Is that correct?