nodejitsu / nodejitsu-api Goto Github PK

It appears one cannot call nodejitsu APIs from behind a proxy.

I installed jitsu toolset via npm install jitsu -g. After reading nodejitsu/jitsu#106 I configured my proxy server with a call to npm config set proxy http://<myproxyserver>:<myproxyserverport>. Despite that, jitsu signup was unable to connect to the nodejitsu host.

I submitted pull request #1 with a prospective fix.

@AvianFlu @jesusabdullah I tagged v0.2.1 in this repository for fc2ddfd, but I didn't publish it to npm because there was inconsistent usage in jitsu:

  # Didn't work, but had correct nodejitsu-api call
  $ jitsu apps update

  # Did work, but only because of the bug in `nodejitsu-api` which I fixed in 0.2.1
  $ jitsu deploy

This is a commit in jitsu which makes it work with [email protected]: nodejitsu/jitsu@040a3b3

Please review that and publish nodejitsu-api and jitsu with compatible version(s).

Hi,

According to the docs, when I create a client and then run a logs.byApp, as follows:

var nj = require('nodejitsu-api');

var njc = nj.createClient({
  username: 'wildcardlabs',
  password: 'secret',
  remoteUri: 'https://api.nodejitsu.com'
});

njc.logs.byApp('my-app', 50, function (err, data) {
  console.log(err)
  console.log(data);
});

I get an error:

[Error: Invalid options, must provide a logs service host]

Thus, I've looked into the code and found out that there is a return case when I don't supply "logs.host" in the config.

var njc = nj.createClient({
  username: 'wildcardlabs',
  password: 'secret',
  remoteUri: 'https://api.nodejitsu.com',
  logs: {host:"api.nodejitsu.com"}
});

But when I try with this alteration, I get another error telling that the path does not exist:

{ error: { error: 'Could not find path: /logs/wildcardlabs/my-app/50' } }                

Note: Actual app name has been replaced by "my-app"

Am I missing something or doing something wrong?

This module currently has no test coverage.

Currently it's only possible to set a timeout option for the whole client instance and it needs to be really high as deployments and start operation can take various of minutes. But other API calls such as a simple account details call will also be under that same timeout and having a timeout of 8+ minutes will be to damn high for it. As you want to be able to timeout those requests in timely manner.

Suggested API's

// if there are 2 objects in the arguments assume that the last one is options for the request
client.command('username', data, options, callback)

or something signature breaking

client.timeout(5000).command('username', data, callback)

Add method to enable users to download a snapshot.

PUT/POST.

Confirm still uses any auth from jitsuconf, it should really ignore that information when you are confirming a new user.

This causes a bug in jitsu

Check: https://gist.github.com/fa6f40d1a3f808e23d7c