noboomta / ku-polls Goto Github PK

You have a ./polls directory and mysite/polls.
The latter contains only 1 file.
You should not have (or need) mysite/polls directory.
Could potentially cause you to import the wrong thing.

In mysite/urls.py you map both /polls/ and '' (root url) to the polls app.
Having 2 urls for the same thing is a bad idea.
I think you should apply a better solution for causing / to go to the polls index,
with the duplicate mapping of entire URL tree.
Some of the code you commented out is better choice.

The badges are so that anyone visiting the repository will
immediately see the status that the badges show & any problems.
Hence, they are usually put on one line at the top of README
for visibility.

1. User can specify a date range for the survey or poll.

As Mr James has posted in the classroom this morning, use "poll" instead of "survey" for now.

2. Our product is an easy to use web application that provides ability to submit a choice on poll items.

This is a sales pitch, not a requirement.

"A choice can be submitted on poll items." would be a requirement.

3. User can view or modify one’s choice any time during the polling period.

What happens when someone wants to see a poll that is not open to voting yet? Is that allowed? Can just about anyone vote? Or must they be authenticated first? Addressing these questions in the requirements would make it more complete.

Should not commit .vscode