noamokman / express-json-error-handler Goto Github PK

Hey, can you push a new release that drops that in-production thingie?

Hello,

The handler expects err argument to be of type Error, while in theory you can throw anything in JS - string, number, undefined etc. Universal error handler should expect type of err: unknown.

If the package is still maintained I could work on PR that checks for type of err we get and if it's not Error, construct an actual Error instance before handling it further.

If the package is still maintained, I could work on PR to address this. What do you think?

The way I do it in my current JSON error handling middleware is by using these functions:

function isErrorWithMessage(error: unknown): error is ErrorWithMessage {
  return (
    typeof error === "object" &&
    error !== null &&
    "message" in error &&
    typeof (error as Record<string, unknown>).message === "string"
  );
}

function toErrorWithMessage(maybeError: unknown): ErrorWithMessage {
  if (isErrorWithMessage(maybeError)) return maybeError;

  try {
    return new Error(JSON.stringify(maybeError));
  } catch {
    /**
     * fallback in case there's an error stringifying the maybeError like with
     * circular references or bigint values for example.
     */
    return new Error(String(maybeError));
  }
}

Giving error for below code.
Node version: 20.11.0

import express from "express";
import jsonErrorHandler from "express-json-error-handler";

const app = express();
app.use(jsonErrorHandler());