no23reason / react-geolocated Goto Github PK

After adding the declarations for TypeScript, it would help maintainability to add some test that would ensure those declarations are always up-to-date.

Use semantic-release to manage releases

• Add commitizen
• Add and configure semantic-release

In the current version of the TypeScript typings you can specify the injected props on the resulting component, i.e. you can write something like:

interface IDemoProps {
  label: string;
}

class Demo extends React.Component<IDemoProps & GeolocatedProps, {}> {
  render(): JSX.Element {
    // implementation
  }
}

const Wrapped = geolocated()(Demo);
<Wrapped
  label="Hello"
  isGeolocationAvailable={false} // this should not be possible
/>

I'd like to propagate the location fix to parent elements, but I can't seem to get it right. Would it be possible to adapt the demo to make that function more clear?

Version 15.6.1 of react-dom just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-dom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 16.4.14 of @types/react was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 7.1.0 of eslint-plugin-react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 6.26.0 of babel-core just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-core is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 7.2.1 of eslint-plugin-react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi, sorry if I'm overlooking something obvious but it seems that the suppressLocationOnMount option is not included in the typings file (index.d.ts).

Version 2.30.0 of html-webpack-plugin just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As html-webpack-plugin is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Is there any interest in supporting geolocation.watchPosition()? It has a very similar API to getCurrentPosition() and it should be relatively painless to add support updating the component's state and de-registering the listener on componentWillUnmount.

Happy to take a stab at it if it's something you feel is appropriate for the lib.

Version 2.10.0 of webpack-dev-server was just published.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-dev-server is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I get this error when i use the modal in next.js starter (ssr), that have a npm-shrinkwrap.json file.

Version 6.26.0 of babel-cli just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

As pointed out by @RishabhJain96 props are not being passed to the child component.

Related PR: #14

Version 21.0.2 of babel-jest just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-jest is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Version 2.7.0 of webpack-dev-server just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As webpack-dev-server is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

The devDependency @types/react was updated from 16.4.14 to 16.4.15.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi,

in a Server Side Rendered Setup the component shows up a warning, regardless if client gets a position or not:

Warning: setState(...): Can only update a mounting component. This usually means you called setState() outside componentWillMount() on the server. This is a no-op. Please check the code for the Geolocated(MerchantSearch) component.

Can you check, if you can use the DOM before setting state?

Version 6.26.0 of babel-register just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-register is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.6.2 of react-test-renderer just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-test-renderer is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

With the new support for master/docs location for GitHub pages, it is no longer desirable to maintain the separate gh-pages branch.

Also the demo page is not as clear as desired.

There is an error in the TypeScript typings that does not allow for Functional Stateless Component to be used.

Version 4.4.1 of eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

The boilerplate used to kick-start this repo is overly complex. Things to check:

• .npmignore
• webpack.config
• demo and its styles
• dependencies

I was wondering if this component supports some sort of onLocationChange event which I could update my app's state with when the user changes location? Or would some sort of setInterval be the way to go?

Adding the code coverage tool (probably Coveralls) will help to maintain the code well tested.

First many thanks for this plugin! Great job :)

I do have one minor issue... The plugin seems to ask for permission on site load rather than waiting until someone has pressed a button that initiates this.props.isGeolocationAvailable. Anything I can do to get around this?

Version 7.0.2 of semantic-release just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As semantic-release is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.6.1 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.5.4 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi,

Do you have an example for using it with nextjs? To me it looks like that it won't work. Thanks!

Hello,
This library works great on desktop, is there any way to make it work for ios and android devices? I tested on both and it doesn't seem to work.
Thanks!

Version 6.26.0 of babel-plugin-transform-object-rest-spread just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-plugin-transform-object-rest-spread is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

I don't want the Lat Lng, I am not able to get the city name.

Version 15.6.2 of react-dom just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-dom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

There are libraries like typings-tester, that could be used to replace the ad-hoc testing now in place.

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

There have been updates to the react monorepo:

• • The devDependency react was updated from 16.6.1 to 16.6.2.

• The devDependency react-dom was updated from 16.6.1 to 16.6.2.
• The devDependency react-test-renderer was updated from 16.6.1 to 16.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

With TypeScript type definitions already included and Flow being available on Windows, it makes sense to add definitions for this as well.

There should also be some kind of tests to ensure the declarations are up-to-date (similarly as in #8).

Version 4.4.0 of eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

I would like there to be an option so that the browser prompt

does not appear right away, but instead as a result of a button click or any other user-generated action.

Can there be a function prop (with 3 callback arguments) that triggers the prompt being asked? Something like

function determineLocation() {
  this.props.showLocationPrompt(this.allowed, this.blocked, this.closed)
}
function allowed() {
  // user clicked allow (or had previously given permission to this site to access location)
}
function blocked(firstTime) {
  if (firstTime) {
    // user clicked the Block option
  } else {
    // attempt blocked because of prior blocking
  }
}
function closed() {
  // user chose neither Block or Allow, must have closed the prompt
}

For that blocked function I think including a firstTime argument is necessary (not sure how to access it from browser settings though). When I was testing on localhost, I never saw the prompt to begin with, because it turns out I had previously blocked it and only found that out after looking at the site settings in Chrome:

Knowing whether the location request was blocked by clicking "Block" or due to prior clicking would allow for a more appropriate response message, such as "You have blocked access to location, unable to proceed" vs "You have previously blocked access to location. Please click on Site settings -> Location -> Always allow on this site." [slightly different message depending on the browser].

Version 0.28.5 of css-loader just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As css-loader is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

The devDependency @types/react was updated from 16.7.22 to 16.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 15.5.4 of react-dom just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-dom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

When turning GPS on or off during operation, this.props.isGeolocationEnabled is not toggled in real-time, the change in GPS status props is only available after page reload.

Maybe do a debounce on the prop, but its only available within the child..