Git Product home page Git Product logo

Comments (9)

alyaeanyx avatar alyaeanyx commented on July 17, 2024 3

It does seem like the logo being non-square causes it to be unevenly rescaled on GNOME:
image
This is because the .svg is directly copied over into hicolor/scalable/apps/ alongside the converted .png versions. Perhaps we should consider either making the SVG square or converting it into a square one in icons/Makefile.

Sorry for unearthing this issue after three years by the way 😅

from nixos-artwork.

samueldr avatar samueldr commented on July 17, 2024 2

Can a regular hexagon fit snugly against all sides of a square? Maths says no! :) (At least, not without rotating it a a weird angle.)

Though, what do you mean, you want to see a logo file where the drawing area is square, with the logo appropriately centered?

What would be the use of such file? (It would help to know how it'd be used, I guess)

from nixos-artwork.

samueldr avatar samueldr commented on July 17, 2024 1

Oh, I would assume it's not "right" to have a 512x512 (or 𝒙×𝒙) directory with non-squared images. Keep this open, with actionable task: make the Makefile generate square files.

I believe this is how the png images are generated for use on an installed NixOS system, good thing that apparently nothing fails when using non-square images here.

from nixos-artwork.

ryantm avatar ryantm commented on July 17, 2024

Yes, I was looking for the drawing area to be square.

I am trying to fix this warning message that Discourse keeps warning us about:
discourse_icon_warning

It is asking for a 512x512 px logo.

from nixos-artwork.

ryantm avatar ryantm commented on July 17, 2024

Well, I went ahead and extended the canvas in GIMP and uploaded it. It's weird that the icon directory Makefile generates a folder called 512x512, but the file inside is not that exact dimensions. Is that typical with icons?

from nixos-artwork.

samueldr avatar samueldr commented on July 17, 2024

Don't be sorry, you're right. This isn't looking correct :)

from nixos-artwork.

marcofeltmann avatar marcofeltmann commented on July 17, 2024

I guess the quickest solution at least for the svg and png would be adding a bunch of transparent bars above and below to mock some square-ish dimensions.

A special logo-squared.png should be the best fit for not breaking systems that require the file dimensions being equal to the content's bounding box.

from nixos-artwork.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.