Git Product home page Git Product logo

dukascopy's People

Contributors

ninety47 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

dukascopy's Issues

the code does not work properly with certain files

Hi,
I use your library to decompress files but with file 13h_ticks.bi5 and 21h_ticks.bi5 of day september 30 2020 ,these files fail to decompress,and deep down the code,decompress function reads file size +1 which makes file size verification fails.
I tried for two weeks to fix this but i could not.
what do you think the source for this error

Months are zero indexed

The epoch is extracted from the URL (and the folder structure I've used to store the files on disk). It represents the point in time that the file starts from e.g. 2013/01/14/00h_ticks.bi5 has the epoch of midnight on 14 January 2013.

2013/01/14/00h_ticks.bi5 has the epoch of midnight on 14 February 2013.

Pass by reference instead of by pointer.

Ticketed raised of this bit of coded (check for others):

tick_data* read_bi5(
        unsigned char *lzma_buffer, size_t lzma_buffer_size, 
        pt::ptime epoch, float point_value, size_t *buffer_size);

should be:

tick_data* read_bi5(
        unsigned char *lzma_buffer, size_t lzma_buffer_size, 
        pt::ptime epoch, float point_value, size_t &buffer_size);

Unit-tests

Convert test programs to proper unit tests.

Dependency clean up.

Tasks for this issue are to:

  • Remove unittest-cpp submodule
  • Move sub-modules from ./opt in ./lib

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.