nimeshnayaju / y-presence Goto Github PK

Hi,
This may be a very silly and rookie question. Can we implement live cursors using WebRTC instead of WebSocket?
I tried but looks like only local user state is set and tracked.

Hi, i am currently working on team project using yjs, y-presence and react(typescript).
i got this error and i can't solve it. can i please get some help? thank you in advance.

ERROR in ./node_modules/y-presence/dist/index.mjs 2:0-99
Module not found: Error: Can't resolve 'use-sync-external-store/shim/with-selector' in '/Users/kcw2297/Desktop/Drawing-Duo/node_modules/y-presence/dist'
Did you mean 'with-selector.js'?
BREAKING CHANGE: The request 'use-sync-external-store/shim/with-selector' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

Thanks for the library, it is great. Also would be nice to have an ability to return only other users from useUsers. Maybe useUsers should have optional options argument for selector function and equality function, where in addition excludeSelf could be presented. What do you think?

Example:

const otherUsers = useUsers(awareness, {
  selector: (state) => state,
  excludeSelf: true,
});

useSelf works well in most situations. But when I use it with TipTap editor and CollaborationCursor extension here comes an issue:

In a component that renders tipTap editor I need to update the presence of the user like this:

const self = useSelf();
useEffect(() => {
  if (!self || !editor) return;
  editor.commands.updateUser({
    name: self.username,
    color: self.color,
  });
}, [self, editor]);

Unfortunately this code makes tiptap editor opened websocket to go mad and infinity send a huge amount of messages.

I have create this hook:

import { isEqual } from "lodash-es";
import { useSelf as usePresenceSelf } from "y-presence";

export const useSelf = () => {
  const self = usePresenceSelf(awareness) as YUser;
  const selfRef = useRef(self);
  useEffect(() => {
    if (isEqual(self, selfRef.current)) return;
    selfRef.current = self;
  }, [self]);
  return selfRef.current;
};

Now update is working as expected and there is no infinite loop of messages anymore.

Should this be added in the y-presence lib? What do you think?