nikolockenvitz / sap-addon Goto Github PK

When a user is mentioned in GitHub, the id is not replaced with the name as it should. As this worked before I expect that some of the recent changes broke this.

• update screenshots
• update description of features
• add note on optional permissions?

In the PR commit view (https://{github}/{org}/{repo}/pull/{id}/commits), the user ID is wrapped into a span (<span class="commit-author user-mention" title="{userID}">{userID}</span>), so currently this element isn't covered by any query. I could solve it by adding the following query including a hrefException:

// commit author, direct mentions
_addQuery(`.commit-author.user-mention`, { userMention: true, hrefException: true });

In the PR timeline view (https://{github}/{org}/{repo}/pull/{id}/), the user ID is wrapped into a span (<span class="author text-bold" data-test-selector="pr-timeline-events-commit-actor-name">{userId}</span> and others added x commits y days ago.), so currently this element isn't covered by any query. I could solve it by adding the following query including a hrefException:

// commit author, direct mentions
_addQuery(`.author[data-test-selector="pr-timeline-events-commit-actor-name"]`, { userMention: true, hrefException: true });

Edit: I just noticed, that this only happens if the commit author couldn't be linked to a GitHub user (e.g. because of different email address) but the given user ID could be mapped to an existing GitHub user ID. Still, these queries could be helpful.

In a716b56 the fetch request (to get GitHub username for a certain ID) moved to the background script. But currently background pages don't have permission for GitHub.

As a result, if People is disabled or not accessible and user ID is not in cache, user ID will not be replaced because username is unknown.

Edit: Seems to be an issue only for Firefox

Hi Niko,

If I understand it right, the extensions only make sense for SAP employees (maybe contractors working at SAP). If so, I find the description misleading. Maybe you clarify that it's only for SAP-internal websites:

"Firefox/Chrome Extension for SAP-internal webpages"

Marc
(former SAP)

Atm we look for an HTML element containing href="/id/signin/sso" but now it seems to use href="/id/signin/sso?redirectTo=".
Same problem applies to the url of the second page where we enter the company url. It has been https://app.pluralsight.com/id/signin/sso, now it's https://app.pluralsight.com/id/signin/sso?redirectTo=.

• automatically login to ZenHub
• similar to GitHub login
• investigate how login is done → maybe in a new tab to prevent redirecting to main page and leaving current page

Uncaught (in promise) TypeError: Illegal invocation:
Function must be called on an object of type StorageArea
    at execAsync

bug was probably introduced in 511c6fc

this blocks further chrome releases until solution is found or change is reverted

While trying to access https://github.tools.sap/sf-k8s/pfs-uxr-card-dev-config/blob/master/base/deployment.yaml, the addon keeps reloading the page, see this gif.

I can confirm that this is the only addon responsible for this and that the issue disappears if I turn off 'GitHub sign in automatically'. Other GitHub pages are working fine.

• currently browser.storage.local is used
• could be changed to browser.storage.sync
• which storage to use could be defined in configuration

With the newly introduced optional permissions, there is now the possibility to add new features to the addon - even for new domains and without a permission request that blocks usage/updates of the addon. However, users need to take an action to grant the new permission.

Evaluate whether there could be a notification on updates when new optional permissions are added (e.g., insert a popup on pages where the addon runs). Also, activeTab permission or "*" as optional permission might be something to look into to get something like "Enable all new features automatically" without requiring a user action on update.

For a first-time installation, users should get some notification to do the initial setup (i.e. optionally provide configuration + enable optional permissions).

GitHub: when users react with emojis in Issues/Pull Requests a tooltip will show who reacted with which emoji, the text in the corresponding aria-label of that emoji button needs to be replaced with the username

• separate cache by host
• auto-expire after certain time (e.g. 30 days) -> refetch
• allow users to manage the cache?

outsource common code (LocalStorage, DOM observer, ...) to one file and import it in the content (and maybe even background) scripts

• either somehow bundle files
• or https://github.com/otiai10/chrome-extension-es6-import

Hello,

It would be nice if this extension could offer an auto login option also for Slack, similar to the Mural one, but using a configured workspace (e.g. "sap-btp.slack.com") instead.

Currently, whenever the Slack session is lost or cleared, we are presented with this screen, which is annoying having to type our workspace every time: https://app.slack.com/workspace-signin

PS: I use Slack strictly through the browser, not through its own desktop application.

Thank you and best regards,
Andre

Hi,

as far as I can see, there isn't any SRI entry for this extensions. Is it allowed to use it (without SRI approval) inside SAP?

;-Daniel