nighthawk-apps / zcash-explorer Goto Github PK

Describe the bug
Internal server error on all request to self hosted instance.

To Reproduce
Steps to reproduce the behavior:

1. Build docker image based on "Dockerfile" in main branch
2. Run it
3. Go to home page

Expected behavior
Display explorer

Screenshots
Error in log :
Request: GET / ** (exit) an exception was raised: ** (FunctionClauseError) no function clause matching in anonymous fn/1 in ZcashExplorerWeb.OrchardPoolLive.get_value_pools/1 (zcash_explorer 0.1.0) lib/zcash_explorer_web/live/orchard_pool_live.ex:42: anonymous fn(%{"id" => "transparent", "monitored" => false}) in ZcashExplorerWeb.OrchardPoolLive.get_value_pools/1 (elixir 1.14.4) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2 (zcash_explorer 0.1.0) lib/zcash_explorer_web/live/orchard_pool_live.ex:42: ZcashExplorerWeb.OrchardPoolLive.get_value_pools/1 (zcash_explorer 0.1.0) lib/zcash_explorer_web/live/orchard_pool_live.ex:38: ZcashExplorerWeb.OrchardPoolLive.orchard_value/1 (zcash_explorer 0.1.0) lib/zcash_explorer_web/live/orchard_pool_live.ex:8: anonymous fn/2 in ZcashExplorerWeb.OrchardPoolLive.render/1 (phoenix_live_view 0.17.11) lib/phoenix_live_view/diff.ex:387: Phoenix.LiveView.Diff.traverse/7 (phoenix_live_view 0.17.11) lib/phoenix_live_view/diff.ex:494: anonymous fn/4 in Phoenix.LiveView.Diff.traverse_dynamic/7 (elixir 1.14.4) lib/enum.ex:2468: Enum."-reduce/3-lists^foldl/2-0-"/3

Additional context
Zcash node 5.4.2 from dockerhub "electriccoinco/zcashd"
Dockerfile seems deprecated I had to change IMAGES to get latest version and succeed to build it.

FROM elixir:1.12.2-alpine AS build
replaced by
FROM elixir:1.14-alpine AS build

and

FROM alpine:3.14 AS app
replaced by
FROM alpine:3.17 AS app

Is your feature request related to a problem? Please describe.

On some block explorers I'm able to view the raw transaction as a parsed, pretty-printed JSON blob (and hex):

Describe the solution you'd like

It would be useful for me to have a link like this on Zcash Explorer when viewing transaction details.

Describe alternatives you've considered
I don't see a way to get this information from Zcash Explorer either explicitly as a feature or by some XHR/ API endpoint that I could inspect.

Hey, this explorer is looking great. I have a small suggestion, some values have too many decimal places, for example in the main page:

And in the blockchain info page:

I think it will look a lot better if you can just show lets say 2 decimal places and maybe the full number if you mouse over.

Keep the good work, i might give it a try to having this explorer locally and contribute with changes like this one but not sure when so you might be quicker.

Describe the bug
Following user guide npm install fails:

181 verbose cwd /home/marsh/v4.5.1-1-explorer-patch/zcash-explorer/assets
182 verbose Linux 5.13.0-7614-generic
183 verbose argv "/home/marsh/.nvm/versions/node/v12.19.0/bin/node" "/home/marsh/.nvm/versions/node/v12.19.0/bin/npm" "audit" "fix"
184 verbose node v12.19.0
185 verbose npm  v7.24.2
186 error code ERESOLVE
187 error ERESOLVE could not resolve
188 error
189 error While resolving: [email protected]
189 error Found: [email protected]
189 error node_modules/webpack
189 error   dev webpack@"^4.41.5" from the root project
189 error   peer webpack@">=2" from [email protected]
189 error   node_modules/babel-loader
189 error     dev babel-loader@"^8.0.0" from the root project
189 error   11 more (copy-webpack-plugin, css-loader, file-loader, ...)
189 error
189 error Could not resolve dependency:
189 error peer webpack@">=2" from [email protected]
189 error node_modules/babel-loader
189 error   dev babel-loader@"^8.0.0" from the root project
189 error
189 error Conflicting peer dependency: [email protected]
189 error node_modules/webpack
189 error   peer webpack@">=2" from [email protected]
189 error   node_modules/babel-loader
189 error     dev babel-loader@"^8.0.0" from the root project
189 error
189 error Fix the upstream dependency conflict, or retry
189 error this command with --force, or --legacy-peer-deps
189 error to accept an incorrect (and potentially broken) dependency resolution.
189 error
189 error See /home/marsh/.npm/eresolve-report.txt for a full report.
190 verbose exit 1

To Reproduce
Steps to reproduce the behavior:

1. follow user guide
2. get to npm install part and fails
3. npm audit fix does not resolve error

Expected behavior

Great work, cool that such a tool added to the Zcash ecosystem

Zcash has credible blockchain data and it is important to show holders

Some of this data can be borrowed from Blockchair, they have an API

Of course it would be cool to get that data ourselves without a third party API, but I think that's overkill at this stage

1. Overview data

• price
• circulation
• market cap
• trading volume
• dominance

2. Price charts

• 1 week/ 1 month / 1 year / All time
• ROI vs BTC/USD

3. 24h statistics

• transactions
• average transactions fee with charts 1 month / 3 months / 1 year / all time
• blocks
• avg.time between blocks
• hashrate

4. Total data

• blocks (total + 24h)
• latest block
• height / hash / time / miner / transaction count
• outputs
• addresses

5. Mempool

• transactions
• transactions per second
• outputs

6. All about Zcash blockchain

• blockchain size with charts
• network nodes
• latest block (n minutes ago)
• difficulty with charts 1 month / 3 months / 1 year / all time

Describe the bug
I report it here because Nighthawk wallet issues have been disabled on GitHub (which is absurd). The wallet can't recognize the transaction type when shielding and shows tx as 0 ZEC was sent and it can't show details.

To Reproduce
Steps to reproduce the behavior:

1. Have ZEC on transparent address
2. Shield it via Nighthawk wallet
3. Encounter the issue

Expected behavior
Show information of the tx like any other transparent address tx.

Screenshots

**Smartphone (please complete the

• Device: OnePlus 8
• OS: OxygenOS 13.1
• Version 2.2.12

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is. QR code of address is not displayed in the UI due to Content Security Policy directive violation.

To Reproduce
Steps to reproduce the behavior:

1. Go to '/address/xxx'
2. See error: QR code not displayed correctly. Tested on Brave Browser (v1.32.106 Chromium: 96.0.4664.45) and Firefox (v94.0)

Is your feature request related to a problem? Please describe.
Many transactions in the block explorer are tagged as tx type "Unknown". This makes transaction lists less meaningful at a glance, and is alarming for a casual user.

Describe the solution you'd like
Ideally, these would be attractively tagged appropriately as "Shielding", "Deshielding", "Shielded", and (doubt this applies here) "Public".

Describe alternatives you've considered
I've none. I have considered that my solution might be based on faulty assumptions about the transactions in question.

Additional context
Here are some examples - all have Orchard actions, presumably that's relevant to this issue.

Shielding: https://zcashblockexplorer.com/transactions/c7eb2ac6252fd266a74f5266ed9c1e585571ae941901480053f7886330829dea
Shielded: https://zcashblockexplorer.com/transactions/504f75ba1d7f397216c425e11424ea740215b52e484b469a67dba7923074cbcd
Deshielding: https://zcashblockexplorer.com/transactions/2e6b1180f806af3b4e0b51604a4b846f881db3801a410486269bfda5cb39c716

To Reproduce
Steps to reproduce the behavior:

1. Go to 'a shielded transaction page'
2. See error

Screenshots

Platform:

• OS: Ubuntu 20.04
• Browser v1.40.105 Chromium v103.0.5060.53

Additional context
Likely a problem with Orchard transactions or server error due to recent spike in shielded transactions.