nietras / 1brc.cs Goto Github PK

Hello,

I'm not 100% sure but I think you might cut your last segment to short in FindEndOfFileSegment.

I think you should use span.LastIndexOf(LineFeed); instead of span.IndexOf(LineFeed); as there is, at least in my current exemple, multiple lines present in the 256 byte span (System.Text.Encoding.UTF8.GetString(span) listed 16 lines).

Hope I didn't miss anything, sorry if I did.

Sorry if I made you feel uncomfortable or something...

Let's discuss my measurements here.

I have just spent some time updating your repo to this and making it work again on Linux

But the results were nothing like I had in the preliminary section of my table. (And yes, it was nothing more than preliminary results).

I now see you are quite active right now and maybe be I did run some bad commit.

Please tell me when I could re-run everything from the master head.

Hey @nietras, I just wanted to let you know that I benchmarked my 1brc attempt against your implementation and mentioned you in my README. You've got the fastest established C# implementation I was aware of so it seemed like an important baseline to have. If you have any concerns or questions about what I wrote there (or if you'd like me to remove any of it), just let me know. Thanks!
https://github.com/noahfalk/1brc/tree/main