nicolasgraph / oui_player Goto Github PK

I'm still tracking this down. I'm getting a:

Fatal error: Maximum execution time of 30 seconds exceeded in /home/sites/xxxxxxx/public/textpattern/lib/txplib_misc.php on line 1902

when I activate a few preferences (Soundcloud, Mixcloud, Vimeo, Youtube). I'm not sure if it's related to the amount of DB fields it has to fetch for the whole Preferences screen or if it's related to some of the oui_player preferences. I think it might be an issue with Soundcloud/Mixcloud preferences, although I've to prove that yet.

On oui_player v1.2.1 I was able to pass it an URL for a YouTube playlist, like this one:

https://www.youtube.com/watch?v=k3qgrSon4To&list=PLgkSUkbS9MLs9LSkGlRAJA-dbiaHpycqq

and oui_player will do its magic and output the proper "player" code (ie. the iframe).

Now I've upgraded to v1.3.1 and the plugin isn't outputting any code at all.
I didn't have time to debug it properly (so I could get a quick patch to apply) but it seems it all boils down to this line. oui_player is not extracting the id properly.

$id = preg_match('/([.][a-z]+\/)/', $this->play) ? $this->getInfos()['id'] : $this->play;]

It seems that Bandcamp has been left out from the compiled plugin (and the manifest.json).

PS: thanks for the plugin, I'm starting to tinker with it.

I've noticed that just before the closing </body>', the Vine script (https://platform.vine.co/static/scripts/embed.js`) was being injected on every page I'm using oui_player, even if I'm not embedding Vine content.

To avoid this, I've changed the corresponding properties from protected to private, both in class Provider and on extending class Vine.

Not sure if this is the correct solution and if it will work when embedding Vine content, but at least for me, it stopped injecting the script.

Config.

• Txp v4.7.1;
• oui_player v2.0.0-BETA3;
• oui_provider v1.0.0-BETA4;
• extensions:
  • oui_audio version: v1.0.0-BETA4

Issue

While players are correctly rendered Textpattern complains about both $height and $ratio undefined variables when the only extension plugged is oui_audio.