nicka / serverless-plugin-diff Goto Github PK

When having a large serverless application (imagine over 20 lambdas, plus cloud formation code managing all kinds of resources)

I'd be more interested in running a diff on the cloudformation infra changes alone rather go through all the changes being made to update the lambdas (S3 filenames, hashes, etc)

It would be nice if the plugin would support an option to compare the original and not the processed CF template (getTemplate() property TemplateStage).

Serverless: Load command config
Serverless: Load command config:credentials
Serverless: Load command create
Serverless: Load command install
Serverless: Load command package
Serverless: Load command deploy
Serverless: Load command deploy:function
Serverless: Load command deploy:list
Serverless: Load command deploy:list:functions
Serverless: Load command invoke
Serverless: Load command invoke:local
Serverless: Load command info
Serverless: Load command logs
Serverless: Load command metrics
Serverless: Load command print
Serverless: Load command remove
Serverless: Load command rollback
Serverless: Load command rollback:function
Serverless: Load command slstats
Serverless: Load command plugin
Serverless: Load command plugin
Serverless: Load command plugin:install
Serverless: Load command plugin
Serverless: Load command plugin:uninstall
Serverless: Load command plugin
Serverless: Load command plugin:list
Serverless: Load command plugin
Serverless: Load command plugin:search
Serverless: Load command config
Serverless: Load command config:credentials
Serverless: Load command rollback
Serverless: Load command rollback:function
Serverless: Load command webpack
Serverless: Load command prune
Serverless: Load command diff
Serverless: Load command login
Serverless: Load command logout
Serverless: Load command generate-event
Serverless: Load command test
Serverless: Load command dashboard
Serverless: Invoke diff
Serverless: Downloading currently deployed template

Exception -----------------------------------------------

'Stack with id xxxxxxxxx does not exist'

Get Support --------------------------------------------
Docs: docs.serverless.com
Bugs: github.com/serverless/serverless/issues
Issues: forum.serverless.com

Your Environment Information ---------------------------
Operating System: darwin
Node Version: 8.9.1
Framework Version: 1.51.0
Plugin Version: 1.3.10
SDK Version: 2.1.0

https://www.npmjs.com/package/json-diff

Hello, thanks for a nice plugin :)

I am trying to automate some of our tasks, but for that, I'd need the diff to run without the need to pass the --region myregion in the command.

While looking at the code, I noticed it uses this.serverless.service.defaults.region, but I can't find a way to set it, how do I set this default region?

Or in this case, should the line be changed to this.serverless.service.provider.region, or maybe add the provider region to the possible value origins?

I'm preparing changes and deploying them across dev/stage/prod.

I already deploy dev and staging, to be safe I want to do a diff against prod before deployment.

However, the diff will show outdated output (from the stage deployment) rather than production

sls diff --stage prod --region us-east-1

     ApiGatewayRestApi: {
       Properties: {
-        Name: "App1 (Serverless prod)"
+        Name: "App1 (Serverless stage)"
       }
     }
   }
   Outputs: {
     ApiGatewayRestApiId: {
       Export: {
-        Name: "app1-gateway-prod-ExtApiGatewayRestApiId"
+        Name: "app1-gateway-stage-ExtApiGatewayRestApiId"
       }
     }
     ApiGatewayRestApiRootResourceId: {
       Export: {
-        Name: "app1-gateway-prod-ExtApiGatewayRestApiRootResourceId"
+        Name: "app1-gateway-stage-ExtApiGatewayRestApiRootResourceId"
       }
     }
   }
 }

(these changes are not expected, I'm deploying stage: prod, and the name should stay the same)

Related to #14 I guess

I'd suggest

1. Update documentation (Running deploy --noDeploy prior to the diff command, solves the issue, by updating the local cloudformation template), and/or
2. Implement suggestion in #14