nhs-england-tools / update-from-template-app Goto Github PK

Here we have this code:

  # Delete files
  to_delete=$(
    cat $list_of_files_to_update_json \
      | jq -r '.comparison | to_entries[] | select(.value.action == "delete") | .key'
  )
  echo "$to_delete" | while IFS= read -r file; do
    rm -rf $dest_dir/$file
  done

If there are no files marked for deletion, $to_delete isn't empty, it contains a single newline. That means the while loop evaluates once, with rm expanded to rm -rf $dest_dir/. That (rather obviously) breaks subsequent steps. If somehow we'd managed to get to this point with $dest_dir set to an empty string too, that would be... uh... bad, but we're also not asserting there's anything in that variable in this function.

I think the right thing to do is to check for this in the while loop with an if [ ! -z "$file" ]; then... just for robustness, but it might be that we want to tweak the jq invocation somehow too.