nhejazi / nima Goto Github PK

Recent bug fixes in the development version of R, "R-devel",
(see the short thread starting here:
https://stat.ethz.ch/pipermail/r-devel/2018-March/075644.html )
have lead you package to no longer pass 'R CMD check' with
that version of R-devel:

https://www.r-project.org/web/checks/check_results_nima.html

In this case, the reason is a too strict test, you not only
check that the attributes (of a certain data frame) are correct,
but you wrongly also check that the list which
attributes() returns has the attributes in a given order.

Instead please fix your check e.g., to use identical() if
appropriate, because even identical() with its default argument
'attr.as.set = TRUE' does not distinguish objects where only the
attributes are re-ordered.

As per email conversation with CRAN maintainers:

Package has a VignetteBuilder field but no prebuilt vignette index.

Please replace \dontrun{} by \donttest{} or unwap the examples if they can be executed in less than 5 sec per Rd-file.

Please fix and resubmit.

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_nima.html.

Specifically, see the problems shown for the r-devel Debian checks.

These can be reproduced by checking with --as-cran using current
r-devel, which for now sets

R_CLASS_MATRIX_ARRAY=true

in the check environment, to the effect that

R> class(matrix(1 : 4, 2, 2))
[1] "matrix" "array"

(and no longer just "matrix" as before).

According to the R NEWS file,

For now only active when environment variable R_CLASS_MATRIX_ARRAY
is set to non-empty, but planned to be the new unconditional behavior
when R 4.0.0 is released:

matrix objects now also inherit from class "array", namely, e.g.,
class(diag(1)) is c("matrix", "array") which invalidates code
assuming that length(class(obj)) == 1, an incorrect assumption that
is less frequently fulfilled now.

S3 methods for "array", i.e., .array(), are now also
dispatched for matrix objects.

Apparently your package no longer works correctly when
class(matrix(...)) gives a vector of length two: please fix as
necessary.

See
https://developer.r-project.org/Blog/public/2019/11/09/when-you-think-class.-think-again/index.html
for more information about correctly using class() in package code.

Please correct before 2019-12-18 to safely retain your package on CRAN.

As reported by CRAN:

Check Details

Version: 0.4.5
Check: tests
Result: ERROR
     Running ‘testthat.R’ [2s/3s]
    Running the tests in ‘tests/testthat.R’ failed.
    Complete output:
     > library(testthat)
     > library(nima)
     nima: Nima Hejazi's R Toolbox
     Version: 0.4.5
     >
     > test_check("nima")
     ── 1. Failure: attrnames finds the names of the attributes of a data frame (@tes
     attrnames(y) not equal to c("names", "row.names", "class").
     2/3 mismatches
     x[2]: "class"
     y[2]: "row.names"
    
     x[3]: "row.names"
     y[3]: "class"
    
     ══ testthat results ═══════════════════════════════════════════════════════════
     OK: 21 SKIPPED: 0 FAILED: 1
     1. Failure: attrnames finds the names of the attributes of a data frame (@test-attribute_names.R#15)
    
     Error: testthat unit tests failed
     Execution halted
Flavor: r-devel-linux-x86_64-debian-clang 

hexSticker is an R package facilitating the creation of hex stickers from within R. It would be nice to create such a sticker (perhaps using the sketch generously provided by GL?) and include it within the package README.md by generating a README.Rmd file for use with devtools.