ngneat / dag Goto Github PK

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The demo app uses Tailwind, but there are no purge paths set up to slim down the styles

Expected behavior

The paths should be added so that webpack/tailwind can strip unused CSS from the site

Minimal reproduction of the problem with instructions

The change should be added to the tailwind.config.js file in the purge attribute.

What is the motivation / use case for changing the behavior?

This will make the demo app a lot smaller than it currently is.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[x] Other... Please describe:

Expected behavior

The demo app should be deployed to Netlify and updated if necessary on pull request merges.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

The deploy should be automatic so that nobody has to remember to do this.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

There's no way to get the count of children for a given node currently

Expected behavior

Providing a step ID should let you know how many children belong to that step

What is the motivation / use case for changing the behavior?

Some UI decisions may need to be made based off the number of children for a given node. This fixes that.

Other

nodeChildrenCount(stepId: number) {
	const items: Array = this.getSingleDimensionalArrayFromModel();
	const childCount = items.filter((i) => i.parentIds.includes(stepId)).length;
	return childCount;
}

// Tests
it('should return the proper number of children for a given node', () => {
	const items = [
		{ branchPath: 1, name: 'Step 1', parentStepIds: [0], stepId: 1 },
		{ branchPath: 1, name: 'Step 2', parentStepIds: [1], stepId: 2 },
		{ branchPath: 2, name: 'Step 3', parentStepIds: [1], stepId: 3 },
		{ branchPath: 1, name: 'Step 4', parentStepIds: [2], stepId: 4 },
		{ branchPath: 2, name: 'Step 5', parentStepIds: [2], stepId: 5 },
		{ branchPath: 1, name: 'Step 6', parentStepIds: [5, 3], stepId: 6 },
	];
	service.setNewItemsArrayAsDagModel(items);

	const result1 = service.nodeChildrenCount(1);
	expect(result1).toBe(2);

	const result3 = service.nodeChildrenCount(3);
	expect(result3).toBe(1);
});

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Expected behavior

Add the service to manage a DAG model, by allowing to add and remove items and having the model update properly

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[X] Support request
[ ] Other... Please describe:

Is this primarily meant as a visualization tool or a data management solution?

I am looking for a tool to generate a topological sort for a dependency graph, to establish an order of execution for interdependent tasks, and I am not clear if this solution would be useful for my use case.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

There is no function that supports dragging a node to a new position in the model, or moving an existing node from one location to another in the model

Expected behavior

There should be a function that allows you to pass in a step ID for an existing step and its new location. The function would then rearrange the model with the node in the updated location. There could be an option to include its children when moving, or to only move the one node.

If the children are included, then every node that comes after the location that the node is moved to will have to be potentially updated as well. If it's just the one node, and its previous children stay, then the moving node and its previous children will have to be updated.

For example, let's say we want to move node 3:

1 → 2 → 3 would change to 1 → 3 → 2
Or
1 → 2 → 3 → 4 would change to 1 → 3 → 2 → 4 OR 1 → 3 → 4 → 2

In the second example there, with the four nodes, the desired result depends on if the node's children should be moved or not as well.

This gets more complicated as branches are introduced. If a node is being moved:

• and it has branch siblings, then the branch siblings would likely stay, but be updated (since their sibling has left).
• and it is moved to be a child of another parent that already has at least one child (creating multiple branches from one parent) then the branch numbers should be updated properly for all siblings
• and its children are coming along, and those children have a branch, then all nodes after the last child of the node being moved should be set as children of branchPath 1 (this one is definitely more complex)

Take this model:

1
2

3 4

If we are moving node 2 and its branched children up above 1, it should end like this:

2

3 4
1

In this case, node 1 is just updated to be a child of branchPath 1. If only node 2 is moved and not its children, then it would end up like this:

2
1

3 4

And nodes 3 and 4 should be updated to have node 1 be their parent Id, and not node 2.

What is the motivation / use case for changing the behavior?

Some UIs will want to implement drag and drop, and this will help enable it. The service itself won't implement the drag and drop necessarily, unless in the future a component that displays the model is provided and handles drag and drop and stuff like that.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

If you have a graph like this:

  1
2  3

And you want to add a new step above 2, but make it still have a sibling of 3 (so, have step 4 replace step 2 and have step 2 be the child of step 4):
  1
4  3
2

The service currently can't do this. It puts 4 directly below 1 and as the parent of 2 and 3:
  1
  4
2  3

Expected behavior

4 should replace 2 in the graph and 2 should be pushed down one spot

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

There are methods for checking if connecting two nodes would be valid, but no method to actually do the connection

Expected behavior

Add the method that connects the two nodes, calling the check method before doing the connection and updating the observable. Should be one method that updates the observable, one that just returns the single dimensional array (same as addItem and addNewStep, etc).

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

There is no current demonstration of how to use the service.

Expected behavior

A demo app should be added to the repo that can be deployed to Netlify showing how to use the service in a real app.

I'm submitting a...

[ x ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ x ] Support request
[ ] Other... Please describe:

Current behavior

Not able to install the module/package with Angular v14.

Expected behavior

Latest stable version should be installable and compatible with higher Angular versions (14 and above)

Minimal reproduction of the problem with instructions

Install the package in a newly generated Angular 14 project.

What is the motivation / use case for changing the behavior?

Compatibility issues with higher stable versions of Angular (14 and above)

Environment

Angular version: `14.2.12`


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: `16.16.10`  
- Platform:  `Windows` 

Others:

- Package Manager: `npm 9.2.0`
- OS Version: `Windows 10 x64`

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

None of the information for the package is in the package.json

Expected behavior

There should be information about the package in the package.json that will show up in NPM

What is the motivation / use case for changing the behavior?

This will give better landing page experience in NPM for users

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The logo.svg and demo.gif are broken on the NPM page

Expected behavior

The two images should show up and not have broken images

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

No documentation for the service currently

Expected behavior

Add full, well written documentation describing how to use the library and set it up properly, along with some examples.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Desired Result

Explain how the add/remove functions decide what to do so that it's clear what the result will be of an add/edit method being called

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The Netlify demo app doesn't have redirects set up

Expected behavior

It should redirect properly so refreshing on a subpage doesn't produce a 404

Minimal reproduction of the problem with instructions

Go to the demo app, click on the demo link, and refresh

I'm submitting a bug

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

given a graph with 2 levels, parent level with 3 nodes, child level with 3 nodes, each pointing to all 3 parents, will duplicate the children level nodes 3 times, producing 9 steps instead of 3.

Expected behavior

only 3 nodes in child level

Minimal reproduction of the problem with instructions

[
  {
    "stepId": 1,
    "parentIds": [0]
  },
  {
    "stepId": 2,
    "parentIds": [0]
  },
  {
    "stepId": 3,
    "parentIds": [0]
  },
  {
    "stepId": 4,
    "parentIds": [0, 2, 3, 1]
  },
  {
    "stepId": 5,
    "parentIds": [0, 2, 3, 1]
  },
  {
    "stepId": 6,
    "parentIds": [0,  2, 3, 1]
  },
  {
    "stepId": 7,
    "parentIds": [0, 6, 5, 4]
  }
]

Environment

Angular version: 13

Browser:
- [X] Chrome (desktop) version latest
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [X] Firefox version 101
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 16.14.2
- Platform:   Windows