Git Product home page Git Product logo

Comments (5)

arose avatar arose commented on May 20, 2024

Hi, thanks for your report.

Yes, I think NGL should use the author supplied names when possible. It is currently not coherent, e.g. auth_seq_id is used but not auth_asym_id. I will look into changing it. There needs to be a fallback if auth_asym_id is not there as it is not required, but label_asym_id is required. Moreover, some data in the mmcif file is linked by the label_asym_id (_pdbx_struct_assembly_gen.asym_id_list), so that field need to be read anyway.

from ngl.

BernierCR avatar BernierCR commented on May 20, 2024

Hi, thanks for your prompt reply.

I put in a dirty hack in my copy for now, to allow my development to continue. I'm not sure if or when I will run into issues because of that. I look forward to your proper fix whenever you get a chance. Next on my list is to extend it's API to support a more convenient to me syntax of custom coloring residues. I can do a pull request for that, but I understand if you don't accept it. That's the beauty of JavaScript, I don't need anything officially added to do it. I can extend at run time.

This project is a lifesaver. I have been using Jmol, but Java is dead. Chrome dropped support, Firefox will be dropping Java support soon, and may other browsers don't have Java support either. JSmol is too slow for large molecules without WebGL. Unless they get serious about making their WebGL version work, NGL Viewer is the best option for sure.

from ngl.

arose avatar arose commented on May 20, 2024

Fixed this in commit 8afe455. Testing appreciated. With that auth_asym_id is used instead of label_asym_id as the chainname. Additionally I made sure that label_asym_id in _pdbx_struct_assembly_gen.asym_id_list and in other places is mapped to the corresponding auth_asym_id during parsing.

from ngl.

arose avatar arose commented on May 20, 2024

Next on my list is to extend it's API to support a more convenient to me syntax of custom coloring residues. I can do a pull request for that, but I understand if you don't accept it.

Please do make a PR or open an issue. I am very happy to discuss the API!

from ngl.

BernierCR avatar BernierCR commented on May 20, 2024

OK great. I'm working on some other parts of my program right now. When I get back to NGL, I will switch to your dev version, test your changes, and develop my api feature.

from ngl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.