Comments (2)
Honestly, I don't know....
I've spent lots of time recently trying to migrate the Three.js version (still an ongoing project) and realized that this library makes breaking changes in the context of NGL every 5-10 minor version bump.
In your experience, how using peerDependencies
instead of dependencies
will help solve the problem you are describing?
A user who needs an updated version of Three.js, can they make it work with NGL if we are using peerDependencies
?
from ngl.
In your experience, how using peerDependencies instead of dependencies will help solve the problem you are describing?
Right now, since I have lint rules set up forbidding importing dependencies that are not in my package.json, I have to add three
as a dependency to my package.json. If NGL upgrades its three version and I don't, there will be two conflicting versions of three installed at use at the same time. Same if I accidentally change the version and get out of sync with NGL. Making it a peer dependency would enforce that if I add it to my package.json, it has to use the same version of three as NGL, preventing the two from getting out of sync.
A user who needs an updated version of Three.js, can they make it work with NGL if we are using peerDependencies?
That user shouldn't be using an updated version of three since it is liable to break NGL though, right? Or are you arguing for the case of the user creating a separate three app that never interacts with NGL? In the latter case I suppose that would be an issue.
I suppose you could make an argument that you should just import ngl's version without adding it to the main package.json, and in my case that just means adding lint rule exclusions. Though it could still create problems if another dependency is used which also has three as a dependency or peer dependency of a conflicting version
from ngl.
Related Issues (20)
- RCSB is deprecating MMTF file format and will stop serve it in July 2024 HOT 1
- ngl/src/store /residue-type.ts isRna() issue HOT 5
- An option to hide intra-protein non-bonded interactions would be nice [feature request] HOT 1
- Use addArrow to add Cartesian axes HOT 1
- dispose() method leaves part of the old representation when changing model HOT 2
- Incorrect behavior when changing opacity for a separate pocket HOT 3
- change color of specific residue HOT 2
- getAtomSetWithinSelection and getAtomSetWithinGroup in several files HOT 4
- info in tooltip HOT 2
- Mass in .pdb files HOT 2
- Focus camera on selection
- Allow more export of components HOT 4
- Why is the effect after superposition not as good as before superposition HOT 1
- Export .pdb file HOT 2
- Question: How to save and restore transformation?
- Funnel like shape
- Multi-touch zoom with multiple NGL instances
- Show connections in two difference files HOT 4
- Hiding non-polar hydrogens HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngl.