Latest examples available on main don't work on the latest Ansible Galaxy release (0.3.3) about ansible-role-nginx-config HOT 17 CLOSED

Sadly, no. Other higher priority tasks have kept me from dedicating as much time as I'd like to the Ansible roles. That being said, what I can do is add a disclaimer to the README for the time being pointing people to the 0.3.3 docs if they are using the latest release (instead of pulling from GitHub).

from ansible-role-nginx-config.

I think the issue is that you are using the configuration syntax that 0.4.0 is going to use when it's released vs the configuration syntax that 0.3.3 uses. Might I suggest pulling the latest commit from main and checking if that works?

from ansible-role-nginx-config.

I seem to be seeing the same issue as reported here.

from ansible-role-nginx-config.

Aaand done 030e282 -- I'm also going to change this issue's title and pin it to try to avoid people loosing unnecessary time figuring out why the latest examples are not working.

from ansible-role-nginx-config.

- name: "edgelb"
  hosts: edgeloadbalancer01
  roles:
  - name: nginxinc.nginx
    vars:
      ansible_become: yes
  - name: nginxinc.nginx_config
    vars: 
      ansible_become: yes
      nginx_config_http_template_enable: true
      nginx_config_http_template:
        - template_file: http/default.conf.j2
          deployment_location: /etc/nginx/conf.d/default.conf
          config:
            upstreams:
              - name: localtest
                servers:
                  - address: localhost:9000
            servers:
              - core:
                  listen:
                    - address: 0.0.0.0
                      port: 80
                locations:
                  - location: /
                    proxy:
                      pass: http://localtest/

posting my ansibleplaybook example for basic setup with 0.4.0. @rolandjitsu

from ansible-role-nginx-config.

For sure. Feel free to open a new issue if you have any questions!

from ansible-role-nginx-config.

I think the issue is that you are using the configuration syntax that 0.4.0 is going to use when it's released vs the configuration syntax that 0.3.3 uses. Might I suggest pulling the latest commit from main and checking if that works?

Yeah, that seems to be issue. I've pulled the last commit and tested it and the config is generated as expected.

from ansible-role-nginx-config.

Indeed, seems that pulling the latest from makes it work. Will this fix make it to the ansible-galaxy repository?

from ansible-role-nginx-config.

It will make it to ansible-galaxy when 0.4.0 is released. That being said, I am holding on releasing 0.4.0 until I finish refactoring the various templates to a more sustainable development model (using macros).

I'll leave this issue open until 0.4.0 is released in case anyone else encounters a similar issue.

from ansible-role-nginx-config.

@alessfg I just burned a couple of hours chasing down why my seemingly valid sytax wasn't working with 0.3.3. Is there an ETA on 0.4.0?

from ansible-role-nginx-config.

Hey @alessfg, Is there a ticket somewhere with what has been completed and needs to be done for the 0.4.0 release?

I would like to make some simple examples/docs, just not sure what state everything is in.

from ansible-role-nginx-config.

If everything goes according to plan, 0.4.0 should be live by end of week.

I originally planned to release it about a month ago once I finished my refactoring efforts, but as is tradition, there were some last minute developments regarding upcoming NGINX releases that delayed the release.

from ansible-role-nginx-config.

I am happy to report that 0.4.0 is finally live! https://github.com/nginxinc/ansible-role-nginx-config/releases/tag/0.4.0

Closing this for the time being since the original issue posted here should hopefully no longer be an issue.

from ansible-role-nginx-config.

- name: "edgelb"
  hosts: edgeloadbalancer01
  roles:
  - name: nginxinc.nginx
    vars:
      ansible_become: yes
  - name: nginxinc.nginx_config
    vars: 
      ansible_become: yes
      nginx_config_http_template_enable: true
      nginx_config_http_template:
        - template_file: http/default.conf.j2
          deployment_location: /etc/nginx/conf.d/default.conf
          config:
            upstreams:
              - name: localtest
                servers:
                  - address: localhost:9000
            servers:
              - core:
                  listen:
                    - address: 0.0.0.0
                      port: 80
                locations:
                  - location: /
                    proxy:
                      pass: http://localtest/

posting my ansibleplaybook example for basic setup with 0.4.0. @rolandjitsu

Has the config spec changed? Because I've tried updating to 0.4.0 yesterday and the generated output wasn't similar to what it was when using fa49aa0.

from ansible-role-nginx-config.

Yep, it has. Long story short I've been slowly refactoring the whole config spec over the last year to make it more sustainable long term. I've tried my best to go in depth over the changes on the CHANGELOG but to be completely honest given that everything has changed in some shape or another it might be easier to recreate the config altogether instead of trying to port it. Not the best scenario I know, but on better news I do not expect the config spec to undergo any further drastic changes down the line.

from ansible-role-nginx-config.

Yep, it has. Long story short I've been slowly refactoring the whole config spec over the last year to make it more sustainable long term. I've tried my best to go in depth over the changes on the CHANGELOG but to be completely honest given that everything has changed in some shape or another it might be easier to recreate the config altogether instead of trying to port it. Not the best scenario I know, but on better news I do not expect the config spec to undergo any further drastic changes down the line.

Ok, I understand. I guess I'll just have to spend a bit of time updating to the new spec.

from ansible-role-nginx-config.

Unpinning this issue as with the latest release the latest examples on main do work with the latest Ansible Galaxy release (0.4.2).

from ansible-role-nginx-config.