Ability to upload snippets about ansible-role-nginx-config HOT 5 CLOSED

@asabhaney I finally got around implementing snippets support in #59.

FWIW, I might revisit how uploading configuration files works for the other nginx_config_*_upload_* variables at some stage (might even remove some of them) since I am not entirely happy with the assumptions/little configurability made behind the scenes by the respective tasks (and I think the snippets option can be used just as well for the main/http/stream configuration upload tasks).

from ansible-role-nginx-config.

Interesting suggestion @asabhaney! I can't promise when/if this will get worked on (there's a few other tasks on the backlog with a higher priority at the moment), but feel free to submit a PR if you want 😄

from ansible-role-nginx-config.

Hey again!

I'm looking at the suggested plugin you shared and I have a couple thoughts about it.

1. The example in that plugin could be replicated using nginx_http_upload_*, although I do get that if you want to upload both config and snippets files to different destination folders, nginx_http_upload_* will only let you choose one source and destination at a time.
2. There is no snippets concept within NGINX's defacto directory structure. That's a concept introduced in the plugin you linked. Not that there's anything wrong with it, but it's not necessarily a recommended folder structure.

Duplicating nginx_http_upload_* to create a nginx_snippets_upload_* variable should be easy enough. A better question would be whether it'd make more sense to let users use a list when using nginx_*_upload_* and in doing so simplify the whole series of upload related variables.

from ansible-role-nginx-config.

Hey @alessfg, thanks for taking the time to look into this! I agree that there's no defacto directory structure references to snippets (though I have seen it scattered throughout Nginx's documentation). I also agree that it's too specific and bloating to add a set of vars (nginx_snippets_upload_*) for it.

I think that being able to upload any additional folders/files to the root nginx directory is a better general solution. Not sure whether that should include replacing vars such as nginx_http_upload_* (not to mention backward breaking), or it should be in the form of something like nginx_other_upload_*, which could take in a list.

from ansible-role-nginx-config.

Great thanks, can't wait to use it!

from ansible-role-nginx-config.