'Remove NGINX Configuration Files' step failing about ansible-role-nginx-config HOT 4 CLOSED

Alright, I'll look into this once I fix some permission issues introduced in Ansible 2.9.12

from ansible-role-nginx-config.

Hey @Migsi! Tests for this parameter are passing just fine. Can you have a look at the test playbook and see if there's anything that you might be missing? https://github.com/nginxinc/ansible-role-nginx-config/blob/main/molecule/common/playbooks/module_converge.yml#L11-L17

from ansible-role-nginx-config.

I might be seeing the same issue on the 0.1.0 release of this role. I don't see any changes since that release that looks like they would affect this behaviour, so I'm guessing it's still a problem.

The problem is that this happens when I'm not explicitly setting nginx_config_cleanup_files in my play:

TASK [nginxinc.nginx_config : (Setup: All OSs) Remove NGINX Configuration Files] ***********************************************************************************************************************************
fatal: [prod.hla.triumf.ca]: FAILED! => {"msg": "Unexpected templating type error occurred on ({{ nginx_config_files.results | default('') | map(attribute='files') | sum(start=[]) | map(attribute='path') | list + nginx_config_cleanup_files | default('') }}): can only concatenate list (not \"str\") to list"}

It looks like nginx_config_cleanup_files is assumed to be a str instead of a list, which messed up the list addition. This value also happens to be commented out in defaults/main/main.yml, so defaulting it to an empty list for the role should probably solve it.

from ansible-role-nginx-config.

I might be seeing the same issue on the 0.1.0 release of this role. I don't see any changes since that release that looks like they would affect this behaviour, so I'm guessing it's still a problem.

The problem is that this happens when I'm not explicitly setting nginx_config_cleanup_files in my play:

TASK [nginxinc.nginx_config : (Setup: All OSs) Remove NGINX Configuration Files] ***********************************************************************************************************************************
fatal: [prod.hla.triumf.ca]: FAILED! => {"msg": "Unexpected templating type error occurred on ({{ nginx_config_files.results | default('') | map(attribute='files') | sum(start=[]) | map(attribute='path') | list + nginx_config_cleanup_files | default('') }}): can only concatenate list (not \"str\") to list"}

It looks like nginx_config_cleanup_files is assumed to be a str instead of a list, which messed up the list addition. This value also happens to be commented out in defaults/main/main.yml, so defaulting it to an empty list for the role should probably solve it.

This seems to nail it. Anyways, I still have to migrate my existing config to the new naming schema that was introduced by the split. That was causing the issue at my side, since nginx_config_cleanup_files was never part of my config.

from ansible-role-nginx-config.