`nginx_http_template.[default].servers.[server1].listen.[listen_items]` is not insertion ordered about ansible-role-nginx-config HOT 4 CLOSED

I do not have any suggestions right now. As you mentioned, lists seem to be the way to go, but it'd be a BC. That being said, as part of an upcoming templating refactor I'm planning on switching to lists whenever possible and that should fix this issue.

from ansible-role-nginx-config.

I had an idea to implement sorting by IP and port to somehow preserve the relation of IP addresses in the config.
Current:
https://github.com/nginxinc/ansible-role-nginx/blob/0922304b12c2dc578f86537f311304ffc498057d/templates/http/default.conf.j2#L82-L84

What I did locally:

{% for listen in (item.value.servers[server].listen.values() | rejectattr("ip", "defined") | sort(attribute='port') + item.value.servers[server].listen.values() | rejectattr("ip", "undefined") | sort(attribute='port') | sort(attribute='ip')) %}
    listen {% if listen.ip is defined and listen.ip | length %}{{ listen.ip }}:{% endif %}{{ listen.port }}{% if listen.ssl is defined and listen.ssl %} ssl{% endif %}{% if listen.opts is defined and listen.opts | length %} {{ listen.opts | join(" ") }}{% endif %};
{% endfor %}

I'm not sure about portability, but it works for me.

So listen will be rendered as:

• First, show everything where the IP is not specified
• Sort them only by port
• Second, show everything where IP and port is specified
• Sort them by IP, then by port (like "order by ip.asc, port.asc")

Results:

    listen 8787 default_server;
    listen 1.2.3.4:80 default_server deferred;
    listen 1.2.3.4:443 ssl http2 default_server deferred;
    listen 1.2.3.4:5757 default_server;
    listen [fe80::a00:abcd::aaaa]:80 default_server deferred;
    listen [fe80::a00:abcd::aaaa]:443 ssl http2 default_server deferred;
    listen [fe80::a00:abcd::bbbb]:80 default_server deferred;
    listen [fe80::a00:abcd::bbbb]:443 ssl http2 default_server deferred;
    listen [fe80::a00:abcd::cccc]:5757 default_server;

from ansible-role-nginx-config.

Hm that could work for the time being. Mind submitting a PR?

from ansible-role-nginx-config.

PR merged 😄

from ansible-role-nginx-config.