Comments (6)
Hey there @BEFH,
it would indeed be great if you could open some PRs for this!
The first thing would be to change the deseq2 module.
I think if possible, you should also provide a test for the new functionality. The current deseq2 tests are done with the mus_musculus dataset, you can find the links to the files here.
If the samplesheet does not contain any info that is suitable to use as a covariate, you could check the test-datasets repo; maybe there is some dataset that already works, otherwise you can possibly provide something suitable?
from differentialabundance.
I think there needs to be some discussion over how to do this. My suggestion of an additional contrast sheet column is one way to do it, or we could automatically detect if the column looks like a float (double in R) before turning it into a factor and instead make sure it's coerced to a double, or there could be a pipeline option to list continuous variables (probably preferable).
from differentialabundance.
Hmm, I'm not sure if adding another param would be the best solution.
As this concerns the contrasts, I think probably your other two suggestions make more sense. The check for numeric values is the easiest solution I think (but must make sure R understands negatives and decimals; yml sometimes struggles with that).
The additional column in the contrasts file is of course more specific, meaning that it would allow people to also have factor variables that are numeric...However, @pinin4fjords, I think for this one would also need to change the validator, no?
from differentialabundance.
This really just needs to be done in more or less the same way as the blocking. So a column for continuous covariates in the contrasts file. Yes, we'd have to make sure the validator understood about the new column, and verified that the listed covariates were present etc.
There's no reason the existing test data can't be adapted, we can add a new fake continuous covariate column- the test data doesn't need to have scientific validity.
from differentialabundance.
My one concern with the design here is whether DESeq2 uses a Type I SS or a Type II SS. If it uses a Type II model, then linear covariates and blocking factors can be in different columns with no issues because order doesn't matter. If it's type I, I don't actually know.
from differentialabundance.
I'm not quite sure what you mean by Type I or II SS, but according to the DESeq2 vignette, the order of variables in the design does not matter (search for order of
, second result).
from differentialabundance.
Related Issues (20)
- Remove parameter --gsea_run HOT 1
- URGENT: pin nf-validation version HOT 2
- Dev version: On parameters website list parameter gene_sets_files in section GSEA HOT 1
- Name of blocking variable not correctly recognized HOT 7
- Please pin the version of the nf-validation plugin! HOT 1
- Error with samplesheet.csv with two column headers that have prefix in common HOT 8
- release differentialabundance HOT 1
- Process `NFCORE_DIFFERENTIALABUNDANCE:DIFFERENTIALABUNDANCE:GTF_TO_TABLE (gencode)` terminated with an error exit status (125) HOT 4
- Error in TABULAR_TO_GSEA_CHIP HOT 1
- GSEA html reports have broken links to png and TSV files HOT 1
- Failed to publish file => double forward slashes
- Auto-format sample names HOT 2
- PosixFileAttributeView
- Missing colour and hover labels in interactive report volcano plot HOT 4
- Normalized/Raw data mishap on the report HOT 1
- Provide a parameter to disable rmarkdown report creation in the differential abundance pipeline HOT 2
- Requests: Enhancements to DESeq2 csv outputs and PDF outputs
- For spike-in analysis, remove control features from outputs
- How to use `--transcript_length_matrix` with nf-core/rnaseq `--aligner star_rsem` output? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from differentialabundance.