Git Product home page Git Product logo

web-combiner's People

Contributors

newghost avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

eins78 mccartney

web-combiner's Issues

CRF line-endings in she-bang break execution on linux

When trying to start "inliner" on Linux, I was getting the following error:

$ ./inliner
: No such file or directory

The CRLF line-endings in the shebang-line seem to be responsible for this behaviour. After removing the "0d"-character from the line first line of the script, it worked.

Fails with some links because http:// gets changed to http:/

Steps to reproduce

  • in the HTML file use a with http://, e.g.:

    <link href="http://softwarerecs.stackexchange.com/feeds/question/9983">
    

or
[https://github.com/mccartney/web-combiner/blob/master/bug-reports/1/small.html]

  • run inliner, e.g.
    inliner small.html a.html

Observed

  • error message:

      fs.js:432
       return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                      ^
    Error: ENOENT, no such file or directory    'http:/softwarerecs.stackexchange.com/feeds/question/9983'
      at Object.fs.openSync (fs.js:432:18)
      at Object.fs.readFileSync (fs.js:289:15)
      at getFile (/usr/lib/node_modules/web-combiner/inliner.js:43:19)
      at Object.<anonymous> (/usr/lib/node_modules/web-combiner/inliner.js:84:20)
      at Function.b.extend.each (/usr/lib/node_modules/web-combiner/jquery-1.9.1.min.js:3:5257)
      at b.fn.b.each (/usr/lib/node_modules/web-combiner/jquery-1.9.1.min.js:3:2013)
      at jsdom.env.done (/usr/lib/node_modules/web-combiner/inliner.js:77:17)
      at /usr/lib/node_modules/web-combiner/node_modules/jsdom/lib/jsdom.js:207:39
      at process._tickCallback (node.js:419:13)
    

Doesn't build on Node 7.0.0

Wouldn't build with newest NodeJS versions, probably with V8 API being changed.

../src/contextify.cc:150:16: error: 'class v8::ObjectTemplate' has no member named 'SetAccessCheckCallbacks'
         otmpl->SetAccessCheckCallbacks(GlobalPropertyNamedAccessCheck,

plus emits a couple more deprecation warnings.

Node version is 7.0.0

Will test with 7.6.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.