The grammar and spelling checking addins fail with error:

And the configuration addin also fails.
The error is simmilar to one reported in nevrome/LanguageToolR#2:

wellspell.addin:::set_config()
#> Error: Unable to access jarfile ~/LanguageTool-4.4/languagetool-commandline.jar
#>Error in languagetool(list_languages = TRUE) : 
#>  The provided executable is not available or does not work correctly. You can install #>LanguageTool with the quick_setup() function.

Session info is the same as in nevrome/LanguageToolR#2.

Can these errors be fixed?

Now the behavior of the add-in is a bit inconsistent: if errors are found, only the erroneous words are kept highlighted. If I select only one word and it has no errors it still is kept highlighted. If the "Markers" tab is closed (as is the case if we work in Rmd files), it's difficult to distinguish between words with and without spelling mistakes.

Related to #5.

Hi all,

This is a very useful package specially for nonative english spekers! Many thanks to the contributors!

I just installed the packages and dependencies as suggested.

The wellspell.addin:::gramcheck() functions works as expected. However, when I run the wellspell.addin:::gramcheck(), I got the language selector pop-up window but then it prints the following error:

Error in rjson::fromJSON(x) :
CHAR() can only be applied to a 'CHARSXP', not a 'NULL'

Any ideas why I am not able to run it?

sessionInfo()
R version 4.2.1 (2022-06-23 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19042)

Matrix products: default

locale:
[1] LC_COLLATE=English_United Kingdom.utf8
[2] LC_CTYPE=English_United Kingdom.utf8
[3] LC_MONETARY=English_United Kingdom.utf8
[4] LC_NUMERIC=C
[5] LC_TIME=English_United Kingdom.utf8

attached base packages:
[1] stats graphics grDevices utils datasets methods base

other attached packages:
[1] shiny_1.6.0

RStudio uses user-friendly names of languages/dictionaries:

Is it possible to use more user-firendly dictionary names for both spellcheking and grammar checking in this addin?

I ran the spellchecked with en_US distionary on the thext:

context <- rstudioapi::getSourceEditorContext()

And got the following error message:

Error : Marker message is unspecified or invalid: rstudioapi<U+2007><U+2007><U+2007><U+2007><U+2007><U+2007><U+2007><U+2007><U+2007><U+2007> | studious

It looks like an encoding issue. Is it possible to get a more informative error message?

A grammar checker for RStudio (especially with knitr) would be extremely helpful. Thank you very much.

Should be more inviting.

Where are these warning messages coming from an how can they be avoided?

> wellspell.addin:::gramcheck()

Listening on http://127.0.0.1:7793

  |==================================================================| 100%
Warning messages:
1: Unknown or uninitialised column: 'context_text'. 
2: Unknown or uninitialised column: 'rule_category_name'. 
3: Unknown or uninitialised column: 'message'. 
4: Unknown or uninitialised column: 'context_text'. 
5: Unknown or uninitialised column: 'rule_category_name'. 
6: Unknown or uninitialised column: 'message'. 

Update the way how RStudio API preferences are accessed. Related to functions .rs.readUiPref() and .rs.writeUiPref(). More details are in #11 and #11 (comment).

If wellspell add-in configuration window is closed via [x] button as shown in the figure, it hangs RStudio and the only option is to kill the program via Task Manager.

In DESCRIPTION file, packages hunspell and LanguageToolR arein section "Suggests":

Suggests:
  hunspell,
  LanguageToolR (>= 0.1.2)

These packages give core functionality for the add-in and dependencies in "Suggests" are not always downloaded. Shouldn't these packages be moved to "Imports" (or even "Depends")?

Non-informative message/output if both 'hunspell' and 'LanguageToolR' are missing.

> wellspell.addin:::gramcheck()

Listening on http://127.0.0.1:7446
Warning: Error in if: argument is of length zero
  81: observeEventHandler [D:/r/wellspell.addin/R/wellspell_config.R#245]
  10: shiny::runApp
   9: shiny::runGadget
   8: set_config [D:/r/wellspell.addin/R/wellspell_config.R#265]
   7: check [D:/r/wellspell.addin/R/wellspell.R#100]
   1: wellspell.addin:::gramcheck [D:/r/wellspell.addin/R/wellspell.R#7]

When using visual markdown mode on Rstudio version 1.4, the addin does not work.

When I try to open "welspell_config" window, on my PC it takes several seconds to open. Sometimes I start doubting if I even pressed the hot-key combination to open the tool.

I did some quick profiling. One of the bottlenecks on LanguageToolR side is function "lato_list_languages"

Next, lato_test_setup() is called several times.

Is it possible to optimize these processes?

Some ideas would be:

• to open window and load contents asynchronously: first, the window could be created and, next, the contents are updated. Some spinner of progress bar could be added to indicate, that the settings are still loading.
• to open the settings of spelling and grammar tools asynchronously (only when required tab is activated). It would be time saver especially if we need only one tool but not both.

The progress bar of spellchecker does not always come to 100%. Here is a print screen:

E.g., when I run the spellchecker tool (en_US dictionary) on the text

  if (as.character(unlist(context$selection)["text"]) == "") {
    stop("No text selected.", call. = FALSE)
  }

I get only 33%:

Is this behavior expected or is there a hidden issue?

I fixed that, but I think now the two setting addins for spell- and grammar check should be completely independent. That's something for the future.

Originally posted by @nevrome in #25 (comment)

Is related to #16

The increase of activity in this repo justifies automatic checks. This should be combined with unit tests, but these might be difficult to design for this package.

Even if the grammar checking tool is used, in configuration gadget the tab with the spellchecking options is opened. It is a bit confusing. It would be better if a correct tab would open. It is even more confusing when "hunspell" is not installed and a warning message appears instead of option to choose the language for grammar checking.

If the add-in is called when no text is selected, the error message appears:
.

No message should appear.

Now wellspell.addin requires the documents to be saved on a hard drive before using the tool:

"Unknown source file path. Is the file where you apply 'wellspell' saved?"

And this creates inconvenience in some situations.

Would it be possible to use the wellspell.addin in new (unsaved) documents?
Should any part of functionality be lost in order to have the feature?

Display source markers with rstudioapi::sourceMarkers.

• spellcheck: Can list spelling suggestions with hunspell::hunspell_suggest
• gramcheck: gramr::check_grammar already provides an explanatory message

When automatic line wrapping is activated, as described here, gramcheck function will mark two mistakes in every line: "This sentence does not star with an uppercase letter" and "Please add a punctuation mark at the end of paragraph".
Is there a way to force it to ignore single line breaks in order to avoid those messages?