Git Product home page Git Product logo

Comments (5)

metalefty avatar metalefty commented on May 26, 2024

I believe it is still safe but test it yourself. At least I don't think to make it configurable is a bad idea but a little bit too much effort than benefit. I think people who want to share a session should revert it by themselves.

from xorgxrdp.

sereeds avatar sereeds commented on May 26, 2024

I apologize, I am not vert familiar with git.

I cloned the git to my local machine.
Then I ran this command inside the dir:
git revert f745376

I get this error:
fatal: bad revision f745376

That commit doesn't appear when I run this command:
git log --oneline

I assume I am doing this wrong.
What is the proper procedure to remove that commit before I build.?

Please and thank you.

from xorgxrdp.

metalefty avatar metalefty commented on May 26, 2024

You don't need to revert in git at all. Just you need to git clone and change the #if 1 to #if 0. Nothing's difficult.

from xorgxrdp.

sereeds avatar sereeds commented on May 26, 2024

That worked great. Thank you very much.

I initially did try making that change shown in the revision, but I figured that I was also supposed to remove that added line shown, LLOGLN....
So that's where I went wrong in changing the source at first. Lesson learnt.

Thanks for the info :-)

from xorgxrdp.

mailinglists35 avatar mailinglists35 commented on May 26, 2024

At least I don't think to make it configurable is a bad idea but a little bit too much effort than benefit

@metalefty is it possible to release two versions then, one with default and one with shared session? as an end user i find it much more difficult to maintain custom builds for all kind of software I use than adding prebuilt binaries from various repos. for example 0.9.8 which fixed the unmounting of fuse shared drive is already available in epel-testing so I would not need to build from sources.

from xorgxrdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.