Buildfailure on Xorg 20 using meson about xorgxrdp HOT 9 CLOSED

I created #122 for this

from xorgxrdp.

Well, I don't know what they guaranteed per spec: defined or defined to 1. In the latter case it's a bug on their side, in the former a reliance on unspecified behavior on this side.

But even in the latter case they might want to transition to only it being defined since the value '1' has no special meaning to them. XvExtension is no single case but it seems that pretty much every extension is handled that way and, with meson, merely defined than defined to a specific value.

If it did have an intended meaning in earlier X versions but they don't this anymore, one could of course check against the X version

#if defined(XvExtension) && (/* X Version >= 1.20 */ || XvExtension)

Since XvExtension will only evaluated when X Version < 1.20 this should work.

from xorgxrdp.

@jsorg71 thoughts on the proposed fix? It seems to be blowing up on Arch.

from xorgxrdp.

Thanks for reporting, I'll take a look. It seems 1.20 was releases May 10 2018.

from xorgxrdp.

This looks like a bug on their side. There is not a good way to fix it on our side.

from xorgxrdp.

checking for Xorg version does not fix it. you need to check for meson. It builds fine with autotools. This is a bug in the meson config in Xorg, it's still under development the way it looks.

from xorgxrdp.

Yes, it's impossible though to check whether the installed system was built using meson or not, however with Xorg 1.20 quite many distributors changed to meson, hence the version check.

We could also just go full-on, and kill the check for the value of `XvExtension* altogether, since I've not seen this anywhere else at all, it's probably code that just "happened to work" anyway. Or is there a specifying that such check is legal or even needed?

from xorgxrdp.

I think we can change it to
#if defined(XvExtension)
and get rid of the second part.
I checked with
meson configure -Dxv=false
and XvExtension is not defined in that case.

from xorgxrdp.

@jsorg71 Yep, this should work, at least for current Xorg, but glanicing into the sources of X makes it look as this should also work for older revisions, so LG2M.

from xorgxrdp.