Git Product home page Git Product logo

Comments (4)

metalefty avatar metalefty commented on May 26, 2024

Thanks for reporting! I'll investigate it when I have time. If you can provide a patch, I'll look at it.

from xorgxrdp.

matt335672 avatar matt335672 commented on May 26, 2024

I've had a look at the excellent concerns @keithrob91 has raised with the static analysis tool.

The basic problem seems that whenever rdpClientConSend() or rdpClientConRecv() detect a connection problem they immediately call rdpClientConDisconnect() which frees the clientCon. it isn't immediately obvious when they are being called. As a result, clientCon could be used after being freed in several locations.

I've got a patch put together which I need to unit test before I submit it. What's the best way to do submit a patch for an issue? Just submit a pull request as usual?

from xorgxrdp.

moobyfr avatar moobyfr commented on May 26, 2024

yes, pull request is the easier method

from xorgxrdp.

matt335672 avatar matt335672 commented on May 26, 2024

This was fixed a long time ago - closing

from xorgxrdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.