netcentric / apply-server Goto Github PK

The description in the readme should include all requests (incl. method, path, parameters and optionally body) with their according response format (status codes, response body).

providing the absolute path to a script within --command option is not working as expected, instead is doing a combination between --destination + absolute path within --command

Compare with Netcentric/accesscontroltool#492.

Currently only for 0 and 1 an IllegalStateException from applyserver itself is thrown, for higher exit codes standard handling of commons exec kicks in. The handling should always be the same.

For long running scripts it would be nice to see what is happening on server side. Obviously, when streaming content already, the response code can not be changed anymore in case of error (it will always be 200) - therefore the idea is to allow for a flag

  -sr, --stream-response    Instead of sending the response back in one 
               chunk after script execution, it will stream back the response as 
               the script is running. The http response code will always be 200 
               for this mode, the script's exit code will be returned as last line 
               of the response. 

Additionally it should also be possible to control the behaviour from calling client:

curl ... -H "Stream-Response: true"

The http header shall take higher precedence over the server start setting

The HTTP standard defines already a "authorization" request header (https://tools.ietf.org/html/rfc7235#section-4.2). This supports multiple types. The one for tokens is "Bearer" (also used in OAuth). This should be used instead (https://tools.ietf.org/html/rfc6750).

At least the license badge and Maven central badge should be included. Once #15 is solved also the Sonarcloud.io badges.

Filtering logs are swallowed in streaming response mode.
Furthermore the log in destination dir should also be written in a streaming way.

Currently, if -o is used to be able to trigger scripts with -c, it always asks for the format parameter even if that format does not make sense because no payload is sent:

Filename needs to be given as path of request or request parameter 'format' has to be used (actual: '/test')

It would be helpful if the readme would contain one script for checking and restarting Apache HTTPD after a new config has been extracted.
I guess the steps are simply

1. apachectl configtest
2. apachectl graceful

But it would be interesting how to properly deal with errors (i.e. configtest not successful).

Currently only http is supported. It should be possible to give an option --https to run the server with https protocol. Additional options will be necessary to specify certificates etc

For both zips and tar it is possible to include symlinks. Those should be expanded as included in archive and filtering must not be active for those entries.