Hello,

I am using 2 instances of a Google Maps datatype on one document type and its is causing a javascript error. It won't load load either of the maps. The error seems to be a google maps issue though:

maps.gstatic.com/cat_js/maps-api-v3/api/js/18/17/%7Bmain,places%7D.js:57 - Uncaught TypeError: undefined is not a function
Have you come across this?

Thanks,

Kenny

Get fix from http://our.umbraco.org/projects/backoffice-extensions/google-maps-property-editor-w-google-places-autocomplete-lookup/bugs,-feedback-and-suggestions/53913-Fix-for-the-resize-bug

See http://our.umbraco.org/projects/backoffice-extensions/google-maps-property-editor-w-google-places-autocomplete-lookup/bugs,-feedback-and-suggestions/53982-Load-resources-over-protocol-relative-URIs

Inside of the GMaps.controller.js file, instead of using:

assetsService.loadJs('http://www.google.com/jsapi')
.then(function () {
Consider using:

assetsService.loadJs('//www.google.com/jsapi')
.then(function () {
The use of a protocol relative URI will stop any errors/blocked loading of the script when running the site under HTTPS.

I used some prevalue fields for localizing the button etc. in my previous pull request. Since then I realised that the way localization is done in Archetype is probably an even better way to go about it. That means that the currently hard coded english texts can also be translated.

Hoping to have a go at it wednesday or in the near future at least :)

It would be nice to have a "Reset" button (which can possibly have a translatable label? Internationalization rocks! ;-)), which would reset the map to it's default starting point.

If umbraco is run on a machine with different local from en-US where decimal mark and thousand separator is not according to en-US, e.g. 123.234.43,55 instead of 123,234,43.55 then the decimal.Parse wont capture the decimal mark in GMapsValueConverter.cs.

I've changed:

Lat = decimal.Parse(coordinates[0]),
Lng = decimal.Parse(coordinates[1])

to

Lat = decimal.Parse(coordinates[0], new System.Globalization.CultureInfo("en-US")),
Lng = decimal.Parse(coordinates[1], new System.Globalization.CultureInfo("en-US"))

When the Umbraco backoffice is accessed with https the map datatype does not load. This is because a javascript reference is using http and the browser blocks it. The javascript reference is

http://our.umbraco.org/projects/backoffice-extensions/google-maps-property-editor-w-google-places-autocomplete-lookup/bugs,-feedback-and-suggestions/53725-Saving-the-zoom-property

When looking up an address, a green bar (notification) appears with the text "undefined: <address>".
Example:

Hi,

I'm having an issue whereby the enter key is grabbed by the Save & Publish, therefore trying to search for a location isn't working in the Place input field. I've tried both the Tab / Enter options and this fails. However the content saves and is always in the default location.

Regards,
Steven

It doesn't work in Nested Content, or archetype because the fields always have the same ID, that way multiple instances wont work.

It would be great if you could create a NuGet package of this editor.

I would be really nice if it was possible to enter some coordinates and a zoom level, which would tell the datatype to show a map showing denmark or belgium at a certain zoom-level for instance.

To prevent exceptions when running a website in other cultures, the parsing of the coordinates should use the InvariantCulture parameter in the file GMapsValueConverter.cs:

decimal.Parse( coordinates[ 0 ], System.Globalization.CultureInfo.InvariantCulture )

Kind Regards,
Gert

When using this great editor in a panel (ie. in a LeBlender editor), the list of location suggestions is not visible.

This is because Umbracos modal have a z-index of 1050, while the location box (I guess it is .pac-container) has a z-index of 1000.