net1957 / proxycheck Goto Github PK

Request

It would be helpful, if proxy check would output environment information - time, client ip. Additionally having the hostname resolved to it's ipv4 address would be very helpful.

Use case

Normally we would consider 10., 192. etc.-addresses to be "DIRECT" reachable, but in some cases we need to send non-local requests via a proxy server, e.g. there's a public domain www1.example.com mapped to a 10.-address.

Would you mind to add an Docker Image? Maybe something based on the given Dockerfile. This example uses the multistage build feature of docker which should be available on hub.docker.com since June 2017.

FROM ruby:2.4
MAINTAINER xxx

ENV RAILS_ENV=production

RUN apt-get update \
  && apt-get install -y libc-dev gcc g++ binutils build-essential

RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - \
  && apt-get install -y nodejs

RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
  && echo "deb http://dl.yarnpkg.com/debian/ stable main" >> /etc/apt/sources.list.d/yarn.list \
  && apt-get update -y \
  && apt-get install -y yarn

ADD src/Gemfile* /tmp/app/
WORKDIR /tmp/app

RUN gem install bundler \
  && bundle install --without development test \
  && bundle update \
  && rm -r /tmp/app/

ADD src/ /srv/app/
ADD files/latest/config/*.rb /srv/app/config/initializers/
WORKDIR /srv/app/

RUN yarn install

RUN sed -i "s/:debug/:info/" config/environments/production.rb

RUN gem install bundler \
  && bundle install --without development test

RUN rake assets:precompile

ENTRYPOINT ["/usr/local/bundle/bin/rails"]
CMD ["server"]

######

FROM ruby:2.4
MAINTAINER xxx

ENV RAILS_ENV=production
ENV RAILS_LOG_TO_STDOUT=true

RUN apt-get update \
  && apt-get install -y nodejs

RUN rm -fr /usr/local/bundle/

COPY --from=0 /usr/local/bundle/ /usr/local/bundle/
COPY --from=0 /srv/app/ /srv/app/

WORKDIR /srv/app/

ENTRYPOINT ["/usr/local/bundle/bin/rails"]
CMD ["server"]

Having an empty PC_PROXY_PAC_URLS would generate an empty input field. Having a predefined PC_PROXY_PAC_URLS variable should generate a drop down field.

Possible format for PC_PROXY_PAC_URLS

PC_PROXY_PAC_URLS=Desc1,http://example.com/proxy1.pac;Desc2,http://example.com/proxy2.pac

I would suggest to split up the two use cases:

• Compress Proxy.pac
• Validate Proxy.pac

and use different forms for this.

When starting the app, it fails with an JavaScript compilation error.

diff --git i/app/assets/javascripts/application.js w/app/assets/javascripts/application.js
index f7cca88..0bcc4ba 100644
--- i/app/assets/javascripts/application.js
+++ w/app/assets/javascripts/application.js
@@ -13,7 +13,6 @@
 //= require jquery
 //= require jquery_ujs
 //= require foundation
-//= require file-saver
 // require turbolinks
 //= require_tree .

@net1957 Thanks a lot for making this application available to the public! Sorry for the long time till I gave you feedback.

1. Easy to use UI

   • I like your lean UI
   • What would help, would be some kind of authentication - at best with support for LDAP

2. Compressing the Proxy.pac

   • Unfortunately does not work in my setup
   • Does it work both with files and pasted proxy.pac?
   • Disable the button for compression via ENV? (This might irritate supporters)

3. Proxy.pac URLs

   • I've got a limited set of Proxy.pac-URLs
   • Would it be possible to have a dropdown list I can configure via ENV?

4. Provide Docker Image

   Would you mind to provide a docker image?