nest-x / nestx-amqp Goto Github PK

It will perform a BREAKING CHANGES from nestx-amqp v1

• using Amqp prefix instead of AMQP (respect case usage)

Hi, the decorator PublishQueue cannot send params to target correctly. Herer is your code

    descriptor.value = async (content) => {
      const context = Reflect.getMetadata(PUBLISH_QUEUE_CONTEXT_METADATA_TOKEN, descriptor.value)
      const producer: Producer = Reflect.getMetadata(PUBLISH_QUEUE_PRODUCER_METADATA_TOKEN, descriptor.value)
      if (producer) {
        await producer.send(content, options)
      }
      await originalHandler.call(context, content, options)
    }

I think it should be write like it

    descriptor.value = async (...content) => {
      const context = Reflect.getMetadata(PUBLISH_QUEUE_CONTEXT_METADATA_TOKEN, descriptor.value)
      const producer: Producer = Reflect.getMetadata(PUBLISH_QUEUE_PRODUCER_METADATA_TOKEN, descriptor.value)
      if (producer) {
        await producer.send(...content, options)
      }
      await originalHandler.call(context, ...content, options)
    }

Hi, the decorator PublishQueue cannot return a value.Herer is your code

    descriptor.value = async (content, ...elseArgs) => {
      const context = Reflect.getMetadata(PUBLISH_QUEUE_CONTEXT_METADATA_TOKEN, descriptor.value)
      const producer: QueueProducer = Reflect.getMetadata(PUBLISH_QUEUE_PRODUCER_METADATA_TOKEN, descriptor.value)
      if (producer) {
        await producer.send(content, options)
      }
      await originalHandler.call(context, content, ...elseArgs)
    }

I think it should be write like it

    descriptor.value = async (content, ...elseArgs) => {
      const context = Reflect.getMetadata(PUBLISH_QUEUE_CONTEXT_METADATA_TOKEN, descriptor.value)
      const producer: QueueProducer = Reflect.getMetadata(PUBLISH_QUEUE_PRODUCER_METADATA_TOKEN, descriptor.value)
      if (producer) {
        await producer.send(content, options)
      }
      return originalHandler.call(context, content, ...elseArgs)
    }
    }

Innestx-amqp , PublishQueue and PublishExchange just send the first argument to consumer now. I don't understand why it is designed like this. I strongly recommend that I should send all arguments to consumer.

ERROR [ExceptionHandler] Nest can't resolve dependencies of the AmqpModule (?). Please make sure that the argument ModuleRef at index [0] is available in the AmqpModule context.

Potential solutions:

• If ModuleRef is a provider, is it part of the current AmqpModule?
• If ModuleRef is exported from a separate @module, is that module imported within AmqpModule?
  @module({
  imports: [ /* the Module containing ModuleRef */ ]
  })

Error: Nest can't resolve dependencies of the AmqpModule (?). Please make sure that the argument ModuleRef at index [0] is available in the AmqpModule context.

Potential solutions:

• If ModuleRef is a provider, is it part of the current AmqpModule?
• If ModuleRef is exported from a separate @module, is that module imported within AmqpModule?
  @module({
  imports: [ /* the Module containing ModuleRef */ ]
  })

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Datasource	Name	Replacement PR?
npm	@types/amqp-connection-manager

Other Branches

These updates are pending. To force PRs open, click the checkbox below.

• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-node action to v4
• chore(deps): update codecov/codecov-action action to v4

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency @nestjs/core to v9 [security]
• chore(deps): update jest monorepo to v29 (major) (@types/jest, jest, ts-jest)
• fix(deps): update dependency @golevelup/nestjs-discovery to v4
• fix(deps): update dependency patch-package to v8
• fix(deps): update dependency rimraf to v5
• fix(deps): update nest monorepo to v10 (major) (@nestjs/common, @nestjs/platform-express, @nestjs/schematics, @nestjs/testing)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

when SubscribeQueue happen error， there is no place to catch errors