neonevm / neon-evm Goto Github PK

In the new version of the Python Solana library (0.8.0) was changed names of InstructionType.
CreateAccountWithSeed -> CREATE_ACCOUNT_WITH_SEED.

It needs to support these changes in our code (see bug neonlabsorg/solana-program-library#192).

┆Issue is synchronized with this Jira Task by Unito

When neon-cli deploy a contract and account of the contract already exists, neon-cli does not print error message

┆Issue is synchronized with this Jira Task by Unito

Need to replace the address calculation algorithm "create2" to "create".

neon-cli: deploy command
evm_loader: finalize instruction

@s-medvedev commented on Tue Mar 09 2021

Fix tests to extracts return value from inner instruction in Solana receipt instead of text logs.

factory.createPair(tokenA, tokenB) consumes too much instructions due to:

• non optimal contract code serialization in the serde
• inefficient serialization of the H160, H256, U256
• valids.rs

The deploying contracts of the uniswap-v2-periphery requires different acc_desc["writable"] values in the emulator and evm_loader.

┆Issue is synchronized with this Jira Task by Unito

It is useful to add logs to the rust-evm implementation to speed up debugging in some cases. However, the logging mechanism is not available there, since this code is used as a library. It is necessary to work out the logging scheme to add debug logs simply. It is worth considering that these logs can be disabled during the build, and this library is also used in two projects (evm-loader, neon-cli) that perform logging in different ways.

┆Issue is synchronized with this Jira Task by Unito

solana-py = https://github.com/michaelhly/solana-py

Symptom: neon-cli fails when try to deploy Ethereum contract with confirmed commitment

STR:

1. Deploy evm_loader and save it address in EVM_LOADER variable
2. Deploy Ethereum contract using

neon-cli deploy --evm_loader $EVM_LOADER --commitment confirmed -vvv <contract>

Actual result:
Fails with error:

ERROR - RPC response error -32002: Transaction simulation failed: Blockhash not found

Expected result:
Successful deployment, awaiting only one confirmation

┆Issue is synchronized with this Jira Task by Unito

Insctuction ExecuteTrxFromAccountDataIterative must be used for deploy contracts and execute transactions

Symptom: CI failed due test_erc20.

STR: On some CI checks.

Actual result:

test_deposit (test_erc20.ERC20test) ... skipped 'not for CI'
token: zNjCu93ddY8JDDDQMCKSrTnueHns4CHiZiQpig7DxKf
 
/bin/sh: 2: --owner: not found
ERR: spl-token error Command 'spl-token --url http://solana:8899 create-account zNjCu93ddY8JDDDQMCKSrTnueHns4CHiZiQpig7DxKf
 --owner AEdjVti6w7Z9CBR4enmnYkuY919ncoqk2wNZLnPaZ5Q4' returned non-zero exit status 127.
ERROR

Expected result:
test_erc20.deposit works.

Additional info:
Solana's address can be of variable length.
For example:

token: 4YHdWdCbu49uoXMRk2SnUuYrCXkpB2hASoimB7mPw7uR <--- success
token: zNjCu93ddY8JDDDQMCKSrTnueHns4CHiZiQpig7DxKf <--- failed

Problem in https://github.com/neonlabsorg/neon-evm/blob/8b60781e49adcdfcce228768f9459a2450d016b9/evm_loader/ERC20/test/test_erc20.py#L95

Some contract use funds which passed through value-field of Ethereum transaction. One of this contract it is WETH contract which provides ERC20 interface for native Ethereum token ETH.

Sometimes the uniswap-interface gets the error "Estimate gas revert".
The probability of an error increases if queries are formed frequently.
After 2-3 seconds the error disappears

┆Issue is synchronized with this Jira Task by Unito

┆Issue is synchronized with this Jira Task by Unito

Use
https://docs.docker.com/engine/reference/builder/#add
to download sources of spl-token from
https://github.com/solana-labs/solana-program-library/releases/tag/token-cli-v2.0.11
and build them in docker

┆Issue is synchronized with this Jira Task by Unito

We need to pass all evm_loader tests on Solana testnet with limited resources.

Problem: Code copy elimination breaks the behavior of the emulator in unexpected situations. The problem is in the implementation, which assumes a rigid arrangement of data in memory.

Solution: Revert code copy elimination.

Possible impact: Contract will take more heap for execution. In any case, we will be within the limits of the testnet.

Reverted PR: neonlabsorg/evm#15 and neonlabsorg/solana-program-library#212