neokii / op4 Goto Github PK

Circuit-Pro@ab22389
https://github.com/Circuit-Pro/openpilot/blob/e4b155b431a680c19d48bc78783be11cca76d60a/selfdrive/controls/lib/longcontrol.py#L27

Add continuous integration please, like comma ai.
Using GitHub actions.

I tried to add it back here but had no luck.
Circuit-Pro@98787cc
Circuit-Pro@da5e409
Circuit-Pro@69ca1fb
It runs with no errors but it’s not showing up on any of the cars. Steering just cuts out with no warning.

https://github.com/Circuit-Pro/openpilot/tree/SPAS

Hi, my 2018 Kia Stinger is experiencing this weird issue where op thinks the SCC set speed is in KPH. For example, I have too set SCC to 96 mph to go 60MPH.
In the 2 pictures, you can see that 34 mph is 54kph and 47 mph is 75 kph.
Not really sure how to fix it but, I love your fork and work!
https://linksharing.samsungcloud.com/tRkMsyaZXPQ0
Thanks for your help in advance!

When engaging open pilot, the car gives an
error message to check the forward collision sensor. And gives a few orange error symbols on the car dashboard. (see attached image)

Device: Comma 2

Car make/model: HYUNDAI KONA EV 2019

I use oricalworks without radar harness

When the car is in reverse gear, the reverse screen does not align, its missing most of it.

Previously, in 085, I was able to use "Sync set speed on gas pressed" without MAD mode enabled. This feature allowed me to press the gas peddle to increase the speed and disengage SCC (as normal) by pressing the break.

Did the change to 086 (op4/hkg_086_dev) require MAD mode enabled to allow this to work?

-=-=-=-=-=-=-=-=-=-=-=-=-=-=
UPDATE 7/19/21: Upon further testing I noticed that when setting the speed for the first time I can continue to increase the gas peddle which DOES increase the set speed. As soon as I let off the peddle and re-engage the gas peddle the system disengages as described above

Every so often auto-resume fails in stop-and-go traffic.
2018 Kia Stinger with HKG Long.

Please fix auto update

When stopping, I got a random solution planner error.

Circuit-Pro@cc1478d

CAR.STINGER: { (Ecu.fwdRadar, 0x7d0, None): [ b'\xf1\x00CK__ SCC F_CUP 1.00 1.01 96400-J5100 \xf1\xa01.01', b'\xf1\x00CK__ SCC F_CUP 1.00 1.03 96400-J5100 \xf1\xa01.03', ], (Ecu.engine, 0x7e0, None): [ b'\xf1\x81606DE051\x00\x00\x00\x00\x00\x00\x00\x00', b'\xf1\x81640E0051\x00\x00\x00\x00\x00\x00\x00\x00', b'\xf1\x82CKJN3TMSDE0B\x00\x00\x00\x00', b'\xf1\x82CKKN3TMD_H0A\x00\x00\x00\x00', ], (Ecu.eps, 0x7d4, None): [ b'\xf1\x00CK MDPS R 1.00 1.04 57700-J5200 4C2CL104', b'\xf1\x00CK MDPS R 1.00 1.04 57700-J5220 4C2VL104', b'\xf1\x00CK MDPS R 1.00 1.04 57700-J5420 4C4VL104', b'\xf1\x00CK MDPS R 1.00 1.06 57700-J5420 4C4VL106', ], (Ecu.fwdCamera, 0x7c4, None): [ b'\xf1\x00CK MFC AT USA LHD 1.00 1.03 95740-J5000 170822', b'\xf1\x00CK MFC AT USA LHD 1.00 1.04 95740-J5000 180504', ], (Ecu.transmission, 0x7e1, None): [ b'\xf1\x87VCJLE17622572DK0vd6D\x99\x98y\x97vwVffUfvfC%CuT&Dx\x87o\xff{\x1c\xf1\x81E21\x00\x00\x00\x00\x00\x00\x00\xf1\x00bcsh8p54 E21\x00\x00\x00\x00\x00\x00\x00SCK0T33NB0\x88\xa2\xe6\xf0', b'\xf1\x87VDHLG17000192DK2xdFffT\xa5VUD$DwT\x86wveVeeD&T\x99\xba\x8f\xff\xcc\x99\xf1\x81E21\x00\x00\x00\x00\x00\x00\x00\xf1\x00bcsh8p54 E21\x00\x00\x00\x00\x00\x00\x00SCK0T33NB0\x88\xa2\xe6\xf0', b'\xf1\x87VDHLG17000192DK2xdFffT\xa5VUD$DwT\x86wveVeeD&T\x99\xba\x8f\xff\xcc\x99\xf1\x89E21\x00\x00\x00\x00\x00\x00\x00\xf1\x82SCK0T33NB0', b'\xf1\x87VDHLG17034412DK2vD6DfVvVTD$D\x99w\x88\x98EDEDeT6DgfO\xff\xc3=\xf1\x81E21\x00\x00\x00\x00\x00\x00\x00\xf1\x00bcsh8p54 E21\x00\x00\x00\x00\x00\x00\x00SCK0T33NB0\x88\xa2\xe6\xf0', b'\xf1\x87VDHLG17118862DK2\x8awWwgu\x96wVfUVwv\x97xWvfvUTGTx\x87o\xff\xc9\xed\xf1\x81E21\x00\x00\x00\x00\x00\x00\x00\xf1\x00bcsh8p54 E21\x00\x00\x00\x00\x00\x00\x00SCK0T33NB0\x88\xa2\xe6\xf0', b'\xf1\x87VDKLJ18675252DK6\x89vhgwwwwveVU\x88w\x87w\x99vgf\x97vXfgw_\xff\xc2\xfb\xf1\x89E25\x00\x00\x00\x00\x00\x00\x00\xf1\x82TCK0T33NB2', b'\xf1\x87WAJTE17552812CH4vfFffvfVeT5DwvvVVdFeegeg\x88\x88o\xff\x1a]\xf1\x81E21\x00\x00\x00\x00\x00\x00\x00\xf1\x00bcsh8p54 E21\x00\x00\x00\x00\x00\x00\x00TCK2T20NB1\x19\xd2\x00\x94', ], },

How can I change virtual set speed or change set speed? So I can update cruise set speed with speed limit from osm? What variable and file location? Scc_smoother.py?

SPAS = smart parking assist messages send

Op currently doesn't cancle the lanechange if a car pops up in blindspot after lane change has started and it's a struggle to fight the steering wheel let's add a feature to cancle lane change if car suddenly pops up in blindspot.

https://api.retropilot.org/useradmin
Add retropilot support for users banned from comma services

please Fix Auto update check button

move-fast/openpilot@7e61993

move-fast/openpilot@53c9b24
Hopefully this will help you improve slow for curves!

When using long-press of the cruise control buttons, the MPH increases/decreases 5mph at a time. Using op4 0.8.9, the speed is rapidly reset to where it was before. Using short-press, you can change the speed 1mph at a time successfully.

Is there a workaround for this?

If you watch the below linked video you'll see the speed jump down 5mph at a time, and then rapidly count back up - the 5mph down at a time is me via buttons, the increase is automatic from OP.

https://youtu.be/0hcEauSaEn8

Neokii thanks for this fork, I really appreciate your work. Can you put back the turn signal indicators and blind spot monitor in openpilot paint.cc. Thanks

https://github.com/Circuit-Pro/openpilot/blob/SPAS

Please add the openpilot tools and the necessary files for setup on an Ubuntu 20.04 pc

Please implement E2E braking like on Arne pilot
https://youtu.be/IaQkj57Qs60

Using this, hkg_086_dev, I get an AEB warning when I start the car.

Circuit-Pro@dfd52f3
Hyundai navigation Speed limit is on CAN bus!!!

Please add support for MDPS Harness on Bus 3 from comma power.
If it's already here please correct me.
Thank You!

Bills Schematic

Connections are fine but the device gives the error listed above. The device is getting information from my car such as the brakes, so I know it is communication on some level, but I cannot engage OP.

Cant disable laneless with ui toggle.

HKG long stopping state creeping into other vehicles consistently on latest neokii hkg_dev with scc ecu on bus 2(radar harness) car is Kia stinger 2018

HKG Long keeps consistently creeping into other vehicles on hkg_dev requiring human intervention, inches away from bumper.

Kia stinger gets wayyyyy too close when creeping In stop and go traffic!

https://github.com/Circuit-Pro/openpilot/tree/OSM

MAD mode triggers check Driver attention warning on 2021 sonata

The desired steering angle is broken on dev_086

Currently, when the C2 is connected, the stock LKA doesn't work. I'd like an option to allow the stock LKA to engage at the standard speed set by the manufacturer, usually 35 MPH.

Kia stinger HKG long bug where 1 out of 10 times it will go to stop then accelerate even closer to bumper some times it gets within inches. Tune is good too just it gets inches away some times. Where the parking sensors go nuts.

Can error on 0.86 while selecting the car FP.
OP doesn’t recognize the car with out select the vehicle FP

Open Street Maps Integration Done, please add to SCC smoother. Slow for curves using map data works! but not speed limit
UI looks very good with signs and everything!
Please check it out I know you can make it even better!
https://github.com/Circuit-Pro/openpilot/tree/OSM-DEV - Works!
https://github.com/Circuit-Pro/openpilot/tree/SPAS-OSM - Works!
https://github.com/move-fast/openpilot/tree/release_0.8.7 - Sources!

67: 8, 68: 8, 127: 8, 304: 8, 320: 8, 339: 8, 356: 4, 544: 8, 593: 8, 608: 8, 688: 5, 809: 8, 832: 8, 854: 7, 870: 7, 871: 8, 872: 8, 897: 8, 902: 8, 903: 8, 916: 8, 1040: 8, 1056: 8, 1057: 8, 1078: 4, 1107: 5, 1136: 8, 1151: 6, 1156: 8, 1168: 7, 1170: 8, 1173: 8, 1265: 4, 1280: 1, 1287: 4, 1290: 8, 1292: 8, 1294: 8, 1312: 8, 1322: 8, 1342: 6, 1345: 8, 1348: 8, 1363: 8, 1369: 8, 1371: 8, 1378: 4, 1384: 8, 1407: 8, 1419: 8, 1427: 6, 1444: 8, 1456: 4, 1470: 8

The OPKR fork gets speed limit data from HKG built-in nav, not camera, which communicates this data on the can bus. The cluster on most HKG cars has a speed limit indicator on the cluster(Like Kia Stinger). The cluster gets this information from the can bus.
Neokii could you please port this feature to your fork as well as the speed limit offset? I gave it a wack but it's above my skill level, Although I'm learning more every day.
Thanks for all your hard and great work, I and the community appreciate it!
Thanks,
John

Osm fully works and use osm data or canbus data of newer Hyundai for speed limit
https://github.com/Circuit-Pro/openpilot
branch “dev” or “test”

Nothing being uploaded

"OpenPilot unavailable waiting for controls to start"
Fork neokii/op4
Branch hkg_085_dev
Device Comma 2 with Black panda

https://github.com/commaai/openpilot/commits/stop-lines

A file explorer would be nice to view dashcam videos on the device.