Improve local module resolution about coc-eslint HOT 5 CLOSED

@javier-garcia-meteologica thank you very much, I was struggling to figure out why coc-eslint was using my system eslint (v7.3.0, currently broken with import/no-cycle) instead of the local one (v7.2, works fine), and adding "eslint.nodePath": "./node_modules", did the trick ❤️

from coc-eslint.

Sorry to kick in like this, but the proposed fix for this issue is the cause of the issue #77.

With all due respect, I'm not sure to understand the issue (and the commit supposed to fix it).

@javier-garcia-meteologica

The variable directory will resolve to /home/user/project. The function call resolveModule('./eslint', '/home/user/project', undefined) will try to read the non-existing directory '/home/user/project/eslint', which will fail.

This is absolutely true, but then the .catch will be invoked, and resolveModule('eslint', directory, nodePath) should be used as a fallback. This fallback will be in charge of resolving the local or global eslint module to use.

I tried to reproduce the issue you are facing. But with the initial condition you are mentioning (empty configuration, local setup of eslint in /project/node_modules/eslint), coc-eslint (before the proposed fix) is successfully resolving to the local eslint install (as shown in :CocInfo). Did I miss something?

from coc-eslint.

If I use the code

      promise = resolveModule('./eslint', directory, nodePath).catch(() => {
        return resolveModule('eslint', directory, nodePath)
      })

Then it resolves to /home/user/.config/yarn/global/node_modules/eslint/lib/api.js instead of <project>/node_modules/eslint

from coc-eslint.

Thanks, I understand the issue now! I'll think of something.

from coc-eslint.

I noticed that reversing the priority order makes module resolution work as expected . It picks up <project>/node_modules/eslint first.

      promise = resolveModule('eslint', directory, nodePath).catch(() => {
        return resolveModule('./eslint', directory, nodePath)
      })

@BenoitZugmeyer, could this fix #77?

from coc-eslint.