Git Product home page Git Product logo

futures-tokio-compat's Introduction

futures-tokio-compat's People

Contributors

nemo157 avatar taiki-e avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

futures-tokio-compat's Issues

Upstream into `tokio-compat`?

Hi @Nemo157,

I'm currently working on a tokio-compat crate in the Tokio repo. Currently, the tokio-compat crate added in tokio-rs/tokio#1663 adds modified versions of tokio's runtimes that can provide a tokio 0.1 reactor and timer, and support spawning both std::future and futures 0.1 tasks. However, another goal for the tokio-compat crate is to provide AsyncRead/AsyncWrite compatibility as well (see tokio-rs/tokio#1549) until compatibility issues between tokio's versions of those traits and futures-io's versions are resolved.

Since you've already written this code, I was wondering if you would be interested in contributing it to the upstream tokio-compat crate? If you're interested, the way I see it, there are two ways we could go about this:

  • once tokio-rs/tokio#1663 lands, you could open a PR to add the AsyncRead/AsyncWrite compat code to the tokio-compat crate (I'd probably place it in a io module and add a default-on feature flag).
  • alternatively, if you're interested in upstreaming this code but don't have time to open a PR, I could open a PR adding this code. I could add attribution to you in the commit that merges your code in.

If you'd prefer not to upstream this crate into tokio-compat, that's also fine, and we can come up with a separate implementation โ€” I just thought that since you've already done the work, it was worth reaching out.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.