nelsondane / fennel-invest-api Goto Github PK

Hi @NelsonDane ,
Can this be used to trade with all my Fennel brokerage accounts at once? Buy the same stock across all of them? I have multiple accounts under my email.
What about if I am using the auto-rsa repo?
Thanks.

I received an image from someone using the repo

I would stop using the repo for the time being. I have reached out to see if we could establish a working relationship to implement an authorized connection.

_verify_credentials will trigger an exception if the credentials file doesn't exist yet (i.e._save_credentials has never completed), but the folder already does exist.

I think this line can be changed to if not os.path.exists(self.path):.

It seems as though when there is an existing pkl that shouldn't be expired is loaded (this can occur from logging into the account from mobile and getting a new email code) then it moves forward without checking authentication somehow. I have not debugged this, and it could be a local modification I have made that is leading to this, so sorry for the poor issue, I just wanted to bring it up in case it's something others have noticed and fixed or noticed and worked around thinking it was just happening to them.

Fix: By deleting the .pkl file it prompts for a new 2FA and everything is normal.

Suggestion: If a 503 [or 401, 403] is received, start auth over - this could obviously be handled on the implementation side, and if it were implemented at the wrapper level, then the auth would need to timestamp the previous attempt or in some other way handle an inf loop of 503s due to actual unavailability.

Reading between the lines of the readme it seems that this is licensed for other people to use, but there is no license file to make that explicit or to explain under what terms it is licensed. Any chance you could add a LICENSE file? I’d suggest a permissive open source license like the Apache or MIT licenses if your goal is to make it as easy as possible to use, which sounds like it was your goal.