Git Product home page Git Product logo

Comments (10)

grubernaut avatar grubernaut commented on July 2, 2024

Can you also try adding the resolve_with_librarian_puppet provisioner parameter to true?

Can you resolve that module with librarian, outside of test-kitchen?

librarian-puppet install?

from kitchen-puppet.

xaniasd avatar xaniasd commented on July 2, 2024

The default value is true, I set it explicitly as well with the same results.
And yes, librarian-puppet install works fine.

from kitchen-puppet.

grubernaut avatar grubernaut commented on July 2, 2024

This is working for me with librarian version 2.0.1, let me test with 2.2.1, as you are using.

from kitchen-puppet.

grubernaut avatar grubernaut commented on July 2, 2024

This is also working for me with version 2.2.1 of librarian.

Do you require your Puppetfile to live outside of your project's root?

from kitchen-puppet.

xaniasd avatar xaniasd commented on July 2, 2024

Hmm, then I'm doing something wrong..
No, the Puppetfile is under <module_root>/spec/fixtures
could you share your example?

from kitchen-puppet.

grubernaut avatar grubernaut commented on July 2, 2024

By convention, the Puppetfile is usually located at the root of the project.

If possible, would you be able to try copying the Puppetfile from /spec/fixtures to the root of your project, and removing the puppetfile_path parameter? I have a feeling it might be the puppetfile_path parameter that has a bug, as all of my tests were with the Puppetfile in the root of the project

from kitchen-puppet.

xaniasd avatar xaniasd commented on July 2, 2024

yep, that did the trick. Thanks a lot! And, we found a bug :)

from kitchen-puppet.

grubernaut avatar grubernaut commented on July 2, 2024

Awesome! Cool, I'll label this as such, and someone will get to it shortly.

from kitchen-puppet.

neillturner avatar neillturner commented on July 2, 2024

I don't think this is a bug as the puppetfile has to be in the root of the project.

see: https://github.com/voxpupuli/librarian-puppet

Every Puppet repository that uses Librarian-puppet may have a file named Puppetfile, metadata.json or Modulefile in the root directory of that repository. The full specification for which modules your puppet infrastructure repository depends goes in here.

not quite sure why we have puppetfile_path. We could copy the puppetfile from the path to the root of the puppet repo but this would change the repo of the user's workstation.

closing.

from kitchen-puppet.

madAndroid avatar madAndroid commented on July 2, 2024

We're experiencing this issue as well; our use case is slightly different, so it does differ from the standard approach of keeping only a single Puppetfile in the root of the repo: we manage two Puppetfiles, one is the "standard" one in the root of the repo, and a Puppetfile used explicitly for testing. This Puppetfile defines test dependencies, which are not necessarily required by the module itself, and are only used during testing in rspec, and originally Beaker as well (we're moving from Beaker to Test-Kitchen).

I'll see if we can implement some logic in our rake tasks to handle this slightly different use case, which will copy the Puppetfile referenced in puppetfile_path to the root of the repo, but it would be great if we didn't have to explicitly do that.

from kitchen-puppet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.