Comments (7)
ytsarev
commented on July 21, 2024
I guess we should not merge pull requests ( #58 ) without rspec tests anymore
from kitchen-puppet.
grubernaut
commented on July 21, 2024
I completely missed that there weren't any tests.
Sorry about this regression, I should have reviewed that better. I'll revert that PR, so master is clean and ask @neillturner if we can pull the 0.0.29 release.
Apologies for any inconvenience this caused
from kitchen-puppet.
neillturner
commented on July 21, 2024
i didn't have time to test. just reviewed code. i will yank the gem. -)
from kitchen-puppet.
grubernaut
commented on July 21, 2024
Thanks @neillturner. Could you also revert the PR? #58
Turns out I don't have revert perms :)
from kitchen-puppet.
neillturner
commented on July 21, 2024
reverted.
from kitchen-puppet.
i11
commented on July 21, 2024
thanks guys!
from kitchen-puppet.
neillturner
commented on July 21, 2024
close as codd reverted. not sure what i'd do about the contribution
from kitchen-puppet.
Related Issues (20)
- Passing custom facts to provisioner that has a hash results in garbage values HOT 1
- No example of facter_file HOT 3
- dependency problems HOT 2
- sync environments dir HOT 3
- exported resources/storeconfigs HOT 1
- Don't copy unneeded files when testing a Puppet module HOT 2
- weird interaction with hiera? HOT 1
- Make puppet_coll_remote_path useable with require_puppet_collections == false HOT 4
- Running specific modules by overriding in command line HOT 1
- fixtures for rspec-puppet cause recursive copy during transferring files stage HOT 1
- puppet release package has been removed from repo HOT 2
- faraday gem conflict - how can I resolve this? HOT 2
- Allow test-kitchen 2.0.0 HOT 2
- puppet collections repo is incorrect HOT 1
- Puppet command not found error HOT 2
- Support for hiera_writer_files on different levels
- apt-transport-https missing HOT 1
- nil `basedir` when instantiating R10K::Puppetfile HOT 1
- How could I upgrade ruby version 2.3 inside puppet agent HOT 1
- debug? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kitchen-puppet.