We need to add docs to our linting for sass & js. I think this should also include desirables (js import order) etc. with a note it is not implemented via the linter

Should be more aptly named

Suggestions:

• Neighborhoods-Facade-Code-Styles
• Facade-Code-Styles
• Neighborhoods-Facade-Code-Styleguide

etc.

Our Custom Linting Rules

• displayName must always be included
• doc Block for esdoc must be correct format
• fetch and defer on components must be static and include dispatch
• Static method/props, prop, constructor, LifeCycle methods, everything else, render last
• Always bind in constructor

Our Available Linting Rules

• 1 component per file
• no _ prefixes
• no extension
• 140 max line lne
• global require only
• underscore dangle
• react/jsx-boolean-value (remove)
• require quotes around object literal property names
• Restrict file extensions that may be required (tweak webpack)
• only .jsx files may have JSX

https://github.com/eslint/eslint/blob/master/docs/rules/valid-jsdoc.md

this will work with jsdoc and esdoc

.eslintrc from Boilerplate...

{
    "import/prefer-default-export": 0,
    "padded-blocks": 0,
    "react/jsx-filename-extension": 0,
    "import/no-extraneous-dependencies": 0,
    "import/extensions": [0, {
      "js": "always",
      "jsx": "always",
      "json": "never"
    }],
    "no-underscore-dangle": 0,
    "space-before-function-paren": 0
 }

• import/prefer-default-export => prefers a default export per file, which breaks with our action creator files
• padding-blocks => I think should be up to the dev
• react/jsx-filename-extension => only issue is the client.js file that contains some XML but is not truly a react file
• import/no-extraneous-dependencies => redux-mock-store etc. not sure on issue here but seems a nuisance, will look into more this week
• no-underscore-dangle => breaks any of our system global __SERVER__ || __DEVELOPMENT__
• space-before-function-paren => do we want to support this? I prefer function() vs function () I think we should change the setting to "never" which would allow only the function()

We should add unit tests for these at somepoint or at least a better way of testing than iterating via patches....

It seems having current implementation is still missing the plugin somehow

Would like to encapsulate all deps in this package and not force user to install deps.