neeoinc / neeo-sdk-examples Goto Github PK

Is there any format you want for branch names (and/or the PR name itself) when doing a pull request? If you take a page from openHAB - the PR (and branch) would be named "XXX-YYY" where XXX is the issue ID and YYY would be some descriptive name. So if I did a pull request based on this issue for an example named 'stuff' - the branch and PR would be named "3-Stuff"

When using the Readme to run the Examples, this is not working as described, also there is no "short" way to start the Listview NOR it is exported as a device to the CLI, or did i oversee something here?

While reading through https://planet.neeo.com/t/k9tnlp and following examples I stumpled upon:

Although not tried, it heavily smells after a typo either here or in the SDK. Shouldn't it be called addButtonHandler ?

Can't seem to get the music player example running correctly. I've started it up, added it to NEEO but the directories are always empty (doesn't show the hardcoded ones in the example) - doesn't seem like the directory stuff is setup correctly?

Secondly - is there any chance you can make the directory stuff optional (if no directories specified, simply bring up the song details popup and leave it that way?). Reason being, many systems stream music and won't have a playlist or any type of queue to manage. Seems like this control is specifically geared towards sonos (which if it is, should be a special type then - not something generic like musicplayer)..