@serializable: Error squiggles in VSCode about needle-engine-support HOT 9 CLOSED

We'll add a fix for this in the next update by supporting both the old and the new decorator syntax:

_propertyKey: string | { name: string }

a call to toString() in this case doesn't make sense since we need the decorated field/property name here. The new method argument (ClassFieldDecoratorContext) has that inside the name property so we have to properly handle both types and extract the information necessary.

That being said our package will continue using experimentalDecorators as long as it's officially supported by typescript to not break backwards compatibility - according to their announcement it won't be removed anytime soon.

from needle-engine-support.

Hey, which version of typescript are you using?

from needle-engine-support.

Oh is this a fault on my end only? Sorry, I'm new to this whole ecosystem.

Anyway, this is what i found:

> npm ls typscript
[email protected]
├─┬ @needle-tools/[email protected]
│ └─┬ @needle-tools/[email protected]
│   └── [email protected]
└── [email protected]

from needle-engine-support.

Thanks, I havent tested it with typescript 5 yet.

Can you try if changing the type to string | symbol works for you as well?
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#more-accurate-type-checking-for-parameter-decorators-in-constructors-under-experimentaldecorators

from needle-engine-support.

Thanks, I havent tested it with typescript 5 yet.

Oh? That's what gets installed automatically using the exporter though? I did not (knowingly) deviate from the defaults.

Can you try if changing the type to string | symbol works for you as well? https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#more-accurate-type-checking-for-parameter-decorators-in-constructors-under-experimentaldecorators

Nope:

from needle-engine-support.

Ah sorry I wasnt aware that it was updated in the vite template. So that can't be it

What do you get when you change it to any to make typescript happy and if(typeof _propertyKey !== "string") console.log(typeof _propertyKey, _propertyKey) ?

from needle-engine-support.

Interesting: Does not log anything. I can set a breakpoint there and it hits (after un-ingoring the file). Is there some magic going on?

from needle-engine-support.

Ah you need to edit the file in lib/engine (the .js file) and not in src/engine

from needle-engine-support.

Looks like in TS5 this parameter is a ClassFieldDecoratorContext instead of a string. My understanding would be that there's different TS versions conflicting, one with a config of experimentalDecorators (like we're using, with the string parameter) and one without.

This issue would likely go away if we switch to TS5 entirely and drop support for experimentalDecorators, instead using the non-experimental ones with that context.

I'm not sure if we can use ClassFieldDecoratorContext as alternative type or if that's just not available in TS4, which would make it seem like "any" and casting to string is the right way for now...

Here are some decorator usage notes for TS5:
https://devblogs.microsoft.com/typescript/announcing-typescript-5-2-beta/#decorator-metadata

https://github.com/microsoft/TypeScript/blob/3ade5022d7f287fdaf61c9e6deed32a3ffb60bc4/src/lib/decorators.d.ts#L326

And the info in the PR that added it is much better than the current docs:
microsoft/TypeScript#50820

from needle-engine-support.