nebulouslabs / go-upnp Goto Github PK

• My router has upnp enabled and initially upnp page shows nothing.
• I clone this repo and run "go test":

--- FAIL: TestConcurrentUPNP (6.43s)
	upnp_test.go:34: context canceled
	...
	upnp_test.go:34: context canceled
--- FAIL: TestIGD (3.13s)
	upnp_test.go:55: Your external IP is: X.Y.Z.W
	upnp_test.go:60: goupnp: error performing SOAP HTTP request: Post http://192.168.1.1:1900/upnp/control/WANIPConn1: EOF
FAIL
exit status 1
FAIL	github.com/NebulousLabs/go-upnp 9.571s

• After that my router's upnp page shows:

ID | App Description | External Port | Protocol | Internal Port | IP Address | Status
1 | upnp test | 9001 | TCP | 9001 | 192.168.1.X | Enabled

• go1.9.2 linux/amd64

We should clear the current port mapping before adding the new one. If an error is returned, it can be ignored.

The code compiles fine but when I run the exe it get stuck at Discover() and then throws this error.

(0x7c4aa0,0xc04200c1d0)panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x465b89]

goroutine 1 [running]:
panic(0x6576e0, 0xc04200c090)
        C:/Go/src/runtime/panic.go:500 +0x1af
github.com/NebulousLabs/go-upnp.(*IGD).ExternalIP(0x0, 0xc04200c1d0, 0xc04200c1d0, 0xc04207bf18, 0x4042e2)
        C:/Users/Abdullah Saleem/Documents/GO/src/github.com/NebulousLabs/go-upnp/upnp.go:54 +0x29
main.main()
        C:/Users/Abdullah Saleem/Documents/GO/Anonymizer/src/main.go:15 +0x6a

I have seen that this is intentionally an opinionated library.. :-) And https://github.com/NebulousLabs/go-upnp/blob/master/upnp.go#L14 states that the forwarding of a port is done for both TCP and UDP on purpose.

Anyway I would think it would be useful to be able to only forward the port for the protocol I need.
Would you accept a PR that adds the two methods ForwardTCP and ForwardUDP?

It would be nice to be able to check/retrieve the currently configured Port Forwardings/Mappings.

According to http://upnp.org/specs/gw/UPnP-gw-WANIPConnection-v1-Service.pdf there are two methods for this GetGenericPortMappingEntry (iterate all existing forwardings) and GetSpecificPortMappingEntry (limited to a set of ext IP, ext Port, Protocol).

Any chance this could be implemented? I would try to work on a PR but I have no experience with Go at all .. :-/

The link: https://godoc.org/github.com/NebulousLabs/upnp is 404