Description

This issue is raised for the usage of beforeDestroy() and destroyed() hooks, which have been deprecated from Vue3 after the release of VueJS 3.x and are replaced by beforeUnmount() and unmounted(), respectively.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/JS-0643/occurrences/

Description

Block comments should have one space before the pound sign # and the comment itself.

Occurrences

There are 78 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E265/occurrences/

Description

Indentation has tabs when only spaces are expected. Change all tabs to spaces.

Occurrences

There are 21 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-W191/occurrences/

Description

There should be only one space before an operator.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E221/occurrences/

Description

It is recommended to provide a key attribute with v-for whenever possible, unless the iterated DOM content is simple, or intentionally relying on the default behavior for performance gains. It also helps to maintain internal component state down the subtree. Even for elements, it's a good practice to maintain predictable …

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0623/occurrences/

Correct me if I'm wrong. As far I understood your process (of serving to the browser is like that)

• User calls site
• python responds with a custom generated html file (per target view) that contains everything
• browser gets this file and loads all other static files (and maybe even the data in another http call? that I don't know yet)
• vue gets created / bootstrapped and the page is done
• until the user clicks to a different page the process starts from 0

I think with that the recreation of the vue app on new click might be "ok" right now but its still alot of repeated overhead

What I suggest would be to go the actual "Single Page Application": Vue compiled once to many static files, which includes the templates that were previously done by python but instead in vue itself - and then python would just have to handle the static and data endpoints - no more also creating the templates with that - which means it saves some CPU work per request

the new user flow would be then like this:

• User calls site
• python serves the static vue app as is
• browser gets this file and loads all other static files
• vue gets created / bootstrapped and the page is done, the vue app itself then gets all the needed data
• when now the user clicks to navigate to a different page
  • it would only load the lazy static files, and just attach it to the current vue instance (you save the bootstrapping here aswell)

If its already like that then I'm happy that this issue can be closed :D

Description

An expression that is not a function call is assigned to nothing. Probably something else was intended here. We recommend to review this.

Occurrences

There are 8 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0106/occurrences/

Example

requirement_results.order_by('requirement_title')[:25]

Is not applied directly to the requirement_results, to do that I need to have the following code

requirement_results = requirement_results.order_by('requirement_title')[:25]

Description

In a wildcard import, all public names defined in the module are imported. It is advised to explicitly import the values needed or modify the module being imported from and define all to restrict the names to be imported.

Occurrences

There are 3336 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0614/occurrences/

Description

Class docstring is missing. If you want to ignore this, you can configure this in the .deepsource.toml file. Please refer to docs for available options.

Occurrences

There are 262 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PY-D0002/occurrences/

Note to self - this is to improve NearBeach's entry to code. Need those comments

Description

An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.

Occurrences

There are 13 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0612/occurrences/

Description

When a loop specifies no break statement, the else clause will always execute when the loop sequence is empty, thus making it useless. It is recommended to have the statements under else in the same scope as the loop itself. If the else clause does not always execute at the …

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0120/occurrences/

The UI is currently being worked on - however has not been mapped for this release as of yet. The following issues will need to be met:

• A style guide on how to call each HTML member i.e.
• The old Django Templates will need to be updated with the new UI. I am creating a kanboard to help track the progress of this
• All functionality will need to be tested after it has been applied

Regards
Luke

When using the "New Document/File" button under the "Document", on edge it does not work

Screenshot Attached
Screenshot URL

Description

In JavaScript, there are two ways to access properties of object: - dot-notation (object.property) ( Recommended ) - square-bracket notation (object["property"]) ( Bad Practice ) The dot notation is often preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.

Occurrences

There are 23 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0049/occurrences/

Description

There should be no spaces before or after the = in a function definition.

Occurrences

There are 10 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E251/occurrences/

Description

It is recommended to use interpolation expressions instead of using v-html as it prevents injection attacks like XSS.

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0693/occurrences/

Notes

If we actually apply what is recommended above, we get some unwanted side effects. Please see image

As per the above image, you can see the output is not present in HTML format, but ASCII instead.

We will need to find a better solution to this problem, as it effect multiple places where users can easily apply the attacks.

Description

If a docstring fits in a single line (72 character according to PEP8), it is recommended to have the quotes on the same line.

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-D200/occurrences/

Description

Two blank lines are expected between functions and classes and one blank line is expected between methods of a class.

Occurrences

There are 32 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E303/occurrences/

https://github.com/robotichead/NearBeach/blob/6606b37e536915f7b78e72ecdf4f0c8cb3ae64d7/NearBeach/models.py#L1889

Do we still need this class/function within the models? Or did we update the permission sets to be separated from this.

Description

Comparisons to the singleton objects, like True, False, and None, should be done with identity, not equality. Use is or is not.

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PTC-W0068/occurrences/

Description

There shouldn't be any blank lines after the function docstring. Remove the blank lines to fix this issue.

Occurrences

There are 59 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-D202/occurrences/

Description

It is recommended to put a newline at the end of the file.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-W292/occurrences/

Description

Line length greater than configured max_line_length detected, defaults to 79 character. This limit can be configured docs

Occurrences

There are 293 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E501/occurrences/

Tips

list_of_opportunity_stage(list_order="6", opportunity_stage_description="Perception Analysis", probability_success="60"),

For the above line, we have the style;

list_of_opportunity_stage(
    list_order="6", 
    opportunity_stage_description="Perception Analysis", 
    probability_success="60"
),

For any Python imports, try and separate the lines with a simple \

from NearBeach.models import kanban_board, \
    kanban_card, \
    opportunity, \
    organisation, \
    quote, \
    project, \
    request_for_change, \
    requirement, \
    requirement_item, \
    task, \
    whiteboard

Good Luck :D

list_of_contact_types(contact_type="Appointment"), is too long - will need to adjust the model so that it can accept this value. Does not work on mysql

Description

An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.

Occurrences

There is 1 occurrence of this issue in the repository.
There is also 1 function call in this repository that needs to be fixed also

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0613/occurrences/

Description

There should be exactly one blank line after the class docstring.

Occurrences

There are 10 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-D204/occurrences/

Description

f-strings are the fastest way to format strings as compared to the following methods: * using format specifiers %

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-C0209/occurrences/

Description

Functions and classes should have two blank lines after them, separating them from other functions and classes.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/FLK-E305/occurrences/

Cards can be added to your board to track the progress of issues and pull requests. You can also add note cards, like this one!

Description

Inline comments should have one space before the pound sign # and the comment itself.

Occurrences

There are 3 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E262/occurrences/

Description

There should be one, and only one, blank line at the end of each file. This warning will occur when there are two or more blank lines.

Occurrences

There are 12 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-W391/occurrences/

Description

Two blank lines are expected between functions and classes and one blank line is expected between methods of a class.

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E303/occurrences/

Description

Semicolons are not needed in Python unless using multiple statements in single line. Use of semi-colons add unnecessary clutter.

Occurrences

There are 3 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0301/occurrences/

Description

In ES2015 (ES6), we can use template literals instead of string concatenation.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0246/occurrences/

Description

Open parentheses should not have any space before or after them.

Occurrences

There are 4 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E211/occurrences/

Description

The use of else or elif becomes redundant and can be dropped if the last statement under the leading if / elif block is a return statement. In the case of an elif after return, it can be written as a separate if block. For else blocks after return, the …

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-R1705/occurrences/

Description

There should be no whitespace after the final character in a line.

Occurrences

There are 16 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-W291/occurrences/

Description

Comparing an object to a literal is usually something you do not want to do, since you can compare to a different literal than what was expected altogether.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/PYL-R0123/occurrences/

Description

It is recommended to have a default value for props that are not marked as required (except Boolean props). Default values are required as these values might not provide, so having a default value is recommended.

Occurrences

There are 130 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0682/occurrences/

Tips

The following are the preferred methods for each variable type;

variableA: {
    type: Number,
    default: 0,
},
variableB: {
    type: String,
    default: "",
},
variableC: Boolean, //Not needed for Booleans :D
variableD: {
    type: Array,
    default: function() {
        return [];
    },
},

Please note the array's default is.... .... .... a function.

Description

Tests for membership should use the form x not in the_list rather than not x in the_list. The former example is simply more readable.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E713/occurrences/

Description

A module or an import name is reimported multiple times. This can be confusing and should be fixed. Please refer to the occurrence message to see the reimported name and the line number where it was imported for the first time.

Occurrences

There are 11 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0404/occurrences/

Description

A malicious actor can gain full control over the user's DOM window object. This can lead to phishing attacks such as fake login prompts or password alerts being shown to the user.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/JS-0712/occurrences/

Description

Two blank lines are expected between functions and classes.

Occurrences

There are 34 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E302/occurrences/

Describe the bug
The latest docker image doesn't work I suspect it is because the image was made on a m1 mac.

To Reproduce
Steps to create the behavior:

1. Pull and run the latest docker tag on nearbeach on a linux machine.
2. Do docker logs and the container name
3. See error

Expected behavior
Near Beach to be running.
Actual Results
It errors :((
Useful infomation
Docker logs https://sourceb.in/5lILRyHUHV
System it is running on https://i.imgur.com/BAwWctT.png

Description

There should be whitespace after the characters ,, ;, and :.

Occurrences

There are 342 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E231/occurrences/

Description

There should be one space before and after all operators.

Occurrences

There are 8 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E225/occurrences/

Description

Line length greater than configured max_line_length detected, defaults to 79 character. This limit can be configured docs

Occurrences

There are 293 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/FLK-E501/occurrences/

Describe the bug

The tests directory at the root location, is causing some confusion. This directory initially was implemented to hold the tests for;

• browser stack
• locust

https://github.com/robotichead/NearBeach/tree/main/tests

*** Ideas to fix ***

Locust is a useful tool for testing NearBeach, it might be an idea to move locust to the root directory with a rename of locust-testing

Description

Method doesn't use the class instance and could be converted into a static method.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-R0201/occurrences

Description

Variables that are not re-assigned are referred to as constant variables. So, we recommend using const for such variables instead of let to define because the value of a variable declared with const remains the same within its scope. It cannot be updated or re-declared and also reduces cognitive load …

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/JS-0242/occurrences/