The wasm files in the res folder are outdated. Personally, I think they should be created when the contracts are built and not kept in this repo.

• Currently, when minting an NFT, the user is attaching 10 NEAR, which is too much in my opinion. It only costs around 0.01 NEAR for storage. I've changed the value to 0.1 NEAR to be safe.

• When attaching 1 yocto, i've changed the parameter to --depositYocto 1 insted of --deposit 0.000...01

• I added some grammar fixes as well.

I did exactly what document said,but always get this error

Hey)

If I understand correctly, this is an example of how to design NTF contracts according to the standard. If the contract is designed according to the standard, then the minted tokens should appear in the wallet. Right?

I deployed the contract and followed all the commands from Readme.md, but I cannot see nft in my wallet.

Network: testnet
Contract: market2.plumb.testnet
Account: vkkliq24.testnet

Follow README to build and get an error.

Error:

error: no matching package named `parity-secp256k1` found
location searched: registry `crates-io`
required by package `near-crypto v0.14.0`
    ... which satisfies dependency `near-crypto = "^0.14"` of package `near-sdk v4.1.1`
    ... which satisfies dependency `near-sdk = "^4.1.1"` of package `approval-receiver v0.0.1 (/Users/mikepurvis/near/NFT/test-approval-receiver)`

Just need to follow the FT example in this same GitHub org

There are some common vulnerabilities and inconsistencies that were found in our fungible token example, many of them are not specific to whether the token is fungible or not fungible. We need to make sure NFT does not have them.

Issues to review:

• https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/near/core-contracts/47
• https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/near/core-contracts/54
• https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/near/core-contracts/55
• https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/near/core-contracts/56
• https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/near/core-contracts/57

In the following line the contract reuses the Set, by using the same prefix for all users

The prefix should uniquely identify the collection. Right now it uses the same prefix for access for all users.

One option is to use prefix like like access-<account_id_hash>

My command:

./scripts/build.rs

Result:

error: no matching package named `parity-secp256k1` found
location searched: registry `crates-io`
required by package `near-crypto v0.14.0`
    ... which satisfies dependency `near-crypto = "^0.14"` of package `near-sdk v4.1.1`

When deploying the token receiver contract and the NFT contract, minting a token and calling nft_transfer_call results in an exceeded prepaid GAS error.

STEPS TO REPRODUCE:

• build and deploy NFT contract and test-token-receiver
• Call new methods on both contracts
• Mint an NFT
• Call nft_transfer_call passing in the test-token-receiver contract as the receiver.

This will result in an exceeded prepaid GAS error as shown here:

Possible solution / where the problem might stem from:
In the core standards repo, the GAS attached to the cross contract call is 30 TGas which can be seen here. This might not be enough.

As an aside - 30 TGas seems like an awful lot of gas and i'm not sure why it would exceed that. In the explorer link here where I only call nft_transfer_call, it uses up 26 TGas before failing at the exceeded prepaid GAS which seems strange to me.

check_token function is not there. and please also explain if wanna add my own function where should i put them??

The primitive types mismatch:

https://github.com/near-examples/NFT/actions/runs/3236353511/jobs/5302044520

• inconsistencies between RS and AS initial steps. i would prefer that these are symmetrical / 100% parity
  https://github.com/near-examples/NFT/blob/master/README.md

• remove simulation unless we're committed to it across both .wasm outputs from RS and AS
  https://github.com/near-examples/NFT/blob/master/package.json#L13

• missing CI for AS
  https://github.com/near-examples/NFT/blob/master/.travis.yml#L13

• start with more tokens?
  https://github.com/near-examples/NFT/blob/master/contracts/assemblyscript/nep4-basic/main.ts#L12

I turn the path to NFT/integration-tests/rs and run thecargo run --example integration-tests.
Then I got 32 erros.
I have already install rust and another Prerequisites but the problem also occur.
I need some help to fix it.

Hi,

I'm trying to build the NEP171 example contract (ver 5d9f516) from scratch on MacOS 11.6, M1 CPU.
Build succeeds, but tests fail here:

   Compiling clang-sys v0.29.3
error[E0425]: cannot find function `get_fault_info` in this scope
   --> /Volumes/External/mykle/Documents/near/figment/flarn2.0/registry/src/github.com-1ecc6299db9ec823/wasmer-runtime-core-near-0.17.1/src/fault.rs:289:21
    |
289 |         let fault = get_fault_info(siginfo as _, ucontext);
    |                     ^^^^^^^^^^^^^^ not found in this scope

An online search for this error string suggested that this might be an issue with the wasm package requiring rust 'nightly' instead of 'stable'. But 'nightly' wasn't able to compile or test the build.

This is supposed to not affect any actual execution result. There might be an underlying issue.

via km1tz on Discord

"The issue is that build script is targeting non existent file (compile.js:18-36)"

Error Message

node:internal/fs/utils:323
    throw err;
    ^

Error: ENOENT: no such file or directory, stat 'out/ts-as.wasm'
    at Object.statSync (node:fs:1132:3)
    at reportFilesize (H:\Programming\NEAR Protocol\NFT-example\contracts\assemblyscript\compile.js:55:20)
    at compileContract (H:\Programming\NEAR Protocol\NFT-example\contracts\assemblyscript\compile.js:38:3)
    at Array.map (<anonymous>)
    at Object.<anonymous> (H:\Programming\NEAR Protocol\NFT-example\contracts\assemblyscript\compile.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1091:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1120:10)
    at Module.load (node:internal/modules/cjs/loader:971:32)
    at Function.Module._load (node:internal/modules/cjs/loader:812:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12) {
  errno: -4058,
  syscall: 'stat',
  code: 'ENOENT',
  path: 'out/ts-as.wasm'
}

Replicated Locally

yarn build:as
yarn run v1.22.5
$ node ./contracts/assemblyscript/compile.js

compiling contract [ nep4-basic/main.ts ] to [ out/nep4-basic-as.wasm ]
 asconfig.js is deprecated use `asb`to build files.  NOTE: output now in ./build/release/ 
asc /Users/jlwaugh/Desktop/NFT/contracts/assemblyscript/nep4-basic/main.ts -O3z --debug --validate --measure --runPasses inlining-optimizing,dce --optimizeLevel 3 --shrinkLevel 3 --target release --binaryFile build/release/main.wasm
WARNING Unknown option '--validate'
I/O Read   :    13.880 ms  n=320
I/O Write  :     3.245 ms  n=1
Parse      :   918.623 ms  n=133
Initialize :    40.810 ms  n=1
Compile    :   327.185 ms  n=1
Emit       :   139.840 ms  n=1
Validate   :   130.952 ms  n=1
Optimize   :  8465.619 ms  n=1
Transform  :          n/a  n=0
internal/fs/utils.js:269
    throw err;
    ^

Error: ENOENT: no such file or directory, stat 'out/nep4-basic-as.wasm'
    at Object.statSync (fs.js:1016:3)
    at reportFilesize (/Users/jlwaugh/Desktop/NFT/contracts/assemblyscript/compile.js:55:20)
    at compileContract (/Users/jlwaugh/Desktop/NFT/contracts/assemblyscript/compile.js:38:3)
    at Array.map (<anonymous>)
    at Object.<anonymous> (/Users/jlwaugh/Desktop/NFT/contracts/assemblyscript/compile.js:5:16)
    at Module._compile (internal/modules/cjs/loader.js:1015:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)
    at Module.load (internal/modules/cjs/loader.js:879:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
  errno: -2,
  syscall: 'stat',
  code: 'ENOENT',
  path: 'out/nep4-basic-as.wasm'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Dependabot encountered the following error when parsing your .dependabot/config.yml:

Automerging is not enabled for this account. You can enable it from the [account settings](https://app.dependabot.com/accounts/near-examples/settings) screen in your Dependabot dashboard.
Automerging is not enabled for this account. You can enable it from the [account settings](https://app.dependabot.com/accounts/near-examples/settings) screen in your Dependabot dashboard.

Please update the config file to conform with Dependabot's specification using our docs and online validator.

As pointed out by external contributor https://stackoverflow.com/questions/65401429/how-to-call-a-near-smart-contract-from-js-with-a-u64-argument NFT implementation uses JSON for its method interfaces, but it also uses u64 which cannot be used with many JSON parsers, including JS. This makes this contract unusable.

My contract was deployed successfully, but I am having issues with the JSON file.

When I run this command:

near call $ID new_default_meta '{"owner_id": "'$ID'"}' --accountId $ID

I get this errors:

Unknown argument

or

SyntaxError: Unexpected token in JSON at position 0 or 1

Any idea? Thanks

Been looking through the library and had noticed that the NFT example technically isn't to spec on the check_access method.

As per spec it states:
export function check_access(token_id: TokenId): boolean;

which translates to:
fn check_access(&self, token_id: TokenId) -> bool;
in Rust.

However, the NFT example has fn check_access(&self, account_id: AccountId) -> bool; as its method.

References:

• NEP4 Spec
• Near NFT example

Mine

I am on Ubuntu and have Rust already installed.

Here are the steps I followed:

• Cloning the repository
• Going into the rust folder
• Following the README.md
• running npm run build:rs throws the following errors
  
• I then went to the prerequisites as detailed here but they are for when Rust is not installed so not helpful in this particular case

@janedegtiareva told me to run the following: rustup target add wasm32-unknown-unknown then running npm run build:rs worked like expected.

PR here:
near/near-sdk-rs#593

Discovered/Documented here:
https://github.com/near-apps/nft-series/issues/1