ndebuhr / sim Goto Github PK

This would speed up the CI a bit. Mostly what's needed is to just cache the /target directory and potentially $CARGO_HOME.

As an added perk, if we integrate criterion, this should let us see performance diffs in CI (criterion saves statistics from its last run under /target).

https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows

For a user using Sim as a Rust library, serialization might be unnecessary and pulling in serde, serde_json and serde_yaml might not make sense. It would probably make sense to put all serialization/deserialization stuff behind a serde feature.

Adding some pub use lines in models/mod.rs could make things a little nicer for importing. There are probably other places.

models::exclusive_gateway::ExclusiveGateway could become models::ExclusiveGateway and models::model::Model could become models::Model.

Reference

I think it would make sense to add some benchmarks to detect performance regressions as we iterate on sim.

criterion is the tool usually recommended for this. Last I checked, it looked rather solid.