nazarpunk / cheapack Goto Github PK

Example:

[←[37m07/29/22 12:05:40←[0m] Parsed wct
[←[37m07/29/22 12:05:40←[0m] Patched wct
[←[37m07/29/22 12:05:40←[0m] ←[36m╨б╨▒╨╛╤А╨║╨░ ╤Г╤Б╨┐╨╡╤И╨╜╨╛ ╨╖╨░╨▓╨╡╤А╤И╨╡╨╜╨░←[0m
[←[37m07/29/22 12:05:40←[0m] ←[36m╨Ч╨░╨┐╤Г╤Б╨║╨░╨╡╨╝ ╤А╨╡╨┤╨░╨║╤В╨╛╤А←[0m
←[33mC:\Warcraft III Public Test\_retail_\x86_64\World Editor.exe←[0m

Two issues above:

1. ANSI color sequences are broken
2. Russian text not displayed properly

I used jsore's guide to setup cheapack with VSCodium. Not only that, I also use Windows 7 + VSCodium.

The build process inside VSCodium is launched as lua53.exe build.lua, I suspect that this is what's causing issues. VSCode uses winpty-agent.exe under the hood for terminal output. Although there're many issues related to it (microsoft/vscode#45693), I think the ultimate problem is Win7's old conhost.exe that's used by lua.exe -> no color support -> VSCode receives garbage data.

As to why Russian output wouldn't work - I have no idea. The language for "Non-Unicode programs" is set to "Russian".

I don't think is can be solved. And I don't think anyone, least of all VSCode, will care about a Win7 setup. I still have to test VSCode and Win10.

Suggested changes to cheapack

Instead, I would like to do this to workaround the issue:

1. Optional translation for cheapack: --language english/russian arg
2. Auto-detect/command switch to toggle colors in output

I will begin working on this if there're no objections.